From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753844AbdIFVhv (ORCPT ); Wed, 6 Sep 2017 17:37:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:50782 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753773AbdIFVhs (ORCPT ); Wed, 6 Sep 2017 17:37:48 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 623E821A95 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Wed, 6 Sep 2017 16:37:46 -0500 From: Bjorn Helgaas To: Randy Dunlap Cc: Stephen Rothwell , Linux-Next Mailing List , Linux Kernel Mailing List , linux-pci , Marc Zyngier , Thomas Gleixner Subject: Re: linux-next: Tree for Sep 6 (*msi.c but ! PCI_MSI) Message-ID: <20170906213745.GB29570@bhelgaas-glaptop.roam.corp.google.com> References: <20170906155720.581b9204@canb.auug.org.au> <20170906180353.GA29570@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 06, 2017 at 11:14:04AM -0700, Randy Dunlap wrote: > On 09/06/17 11:03, Bjorn Helgaas wrote: > > [+cc Marc, Thomas] > > > > On Wed, Sep 06, 2017 at 08:53:04AM -0700, Randy Dunlap wrote: > >> On 09/05/17 22:57, Stephen Rothwell wrote: > >>> Hi all, > >>> > >>> Please do not add any v4.15 related material to your linux-next > >>> included branches until after v4.14-rc1 has been released. > >>> > >>> Changes since 20170905: > >>> > >> > >> on i386: > >> > >> CONFIG_PCI is not enabled, so CONFIG_PCI_MSI is not enabled. > >> > >> > >> ../kernel/irq/msi.c: In function 'msi_domain_alloc_irqs': > >> ../kernel/irq/msi.c:352:19: error: storage size of 'arg' isn't known > >> msi_alloc_info_t arg; > >> ^ > >> > >> ../drivers/base/platform-msi.c:37:19: error: field 'arg' has incomplete type > >> msi_alloc_info_t arg; > >> ^ > > > > Thanks. I assume this is a new regression in next-20170906, since > > you're responding to its announcement? > > Yes, AFAIK. First time that I have seen it. > > > I don't quite see where the problem is yet (looking at next-20170906). > > kernel/irq/msi.c includes linux/msi.h, which includes > > arch/x86/include/asm/msi.h, which includes > > arch/x86/include/asm/hw_irq.h and has a typedef for msi_alloc_info_t, > > but I don't see any CONFIG_PCI guards there that would be relevant. > > CONFIG_GENERIC_MSI_IRQ=y > CONFIG_GENERIC_MSI_IRQ_DOMAIN=y > > Full randconfig file is attached. Thanks, I reproduced the problem. That randconfig doesn't build in v4.12 or v4.13 either (though with slightly different errors). I think the next-20170906 problem is that msi_alloc_info_t is typedef'd to struct irq_alloc_info, which is defined only under #ifdef CONFIG_X86_LOCAL_APIC, which isn't set in this config. This is outside my scope of knowledge, so I'm hoping the problem is obvious to Thomas or Marc. Bjorn