From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com ([192.55.52.93]:7172 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753352AbdIFVnR (ORCPT ); Wed, 6 Sep 2017 17:43:17 -0400 Date: Wed, 6 Sep 2017 17:49:09 -0400 From: Keith Busch To: Christoph Hellwig Cc: sagi@grimberg.me, Akinobu Mita , linux-nvme@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH 3/4] nvme-pci: propagate (some) errors from host memory buffer setup Message-ID: <20170906214909.GI17331@localhost.localdomain> References: <20170906135532.21358-1-hch@lst.de> <20170906135532.21358-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170906135532.21358-4-hch@lst.de> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Sep 06, 2017 at 03:55:31PM +0200, Christoph Hellwig wrote: > We want to catch command execution errors when resetting the device, so > propagate errors from the Set Features when setting up the host memory > buffer. We keep ignoring memory allocation failures, as the spec > clearly says that the controller must work without a host memory buffer. > > Signed-off-by: Christoph Hellwig > Cc: stable@vger.kernel.org Looks good. Reviewed-by: Keith Busch From mboxrd@z Thu Jan 1 00:00:00 1970 From: keith.busch@intel.com (Keith Busch) Date: Wed, 6 Sep 2017 17:49:09 -0400 Subject: [PATCH 3/4] nvme-pci: propagate (some) errors from host memory buffer setup In-Reply-To: <20170906135532.21358-4-hch@lst.de> References: <20170906135532.21358-1-hch@lst.de> <20170906135532.21358-4-hch@lst.de> Message-ID: <20170906214909.GI17331@localhost.localdomain> On Wed, Sep 06, 2017@03:55:31PM +0200, Christoph Hellwig wrote: > We want to catch command execution errors when resetting the device, so > propagate errors from the Set Features when setting up the host memory > buffer. We keep ignoring memory allocation failures, as the spec > clearly says that the controller must work without a host memory buffer. > > Signed-off-by: Christoph Hellwig > Cc: stable at vger.kernel.org Looks good. Reviewed-by: Keith Busch