From: Wei Liu <wei.liu2@citrix.com>
To: Bhupinder Thakur <bhupinder.thakur@linaro.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 22/27 v8] xen/arm: vpl011: Add support for vuart console in xenconsole
Date: Thu, 7 Sep 2017 10:08:41 +0100 [thread overview]
Message-ID: <20170907090841.rtm7cyidsfh7hx4k@citrix.com> (raw)
In-Reply-To: <CACtJ1JR8byUgp1AW9SQ5xuYtcKbUZx60WzJcSX6PeBCmiL5+Ww@mail.gmail.com>
On Wed, Sep 06, 2017 at 10:59:05PM +0530, Bhupinder Thakur wrote:
> On 5 September 2017 at 15:01, Wei Liu <wei.liu2@citrix.com> wrote:
> > On Mon, Sep 04, 2017 at 09:58:07PM +0530, Bhupinder Thakur wrote:
> >> Hi Jan,
> >>
> >>
> >> On 28 August 2017 at 14:41, Jan Beulich <JBeulich@suse.com> wrote:
> >> >>>> On 28.08.17 at 10:56, <bhupinder.thakur@linaro.org> wrote:
> >> >> --- a/config/arm32.mk
> >> >> +++ b/config/arm32.mk
> >> >> @@ -1,5 +1,6 @@
> >> >> CONFIG_ARM := y
> >> >> CONFIG_ARM_32 := y
> >> >> +CONFIG_VUART_CONSOLE := y
> >> >> CONFIG_ARM_$(XEN_OS) := y
> >> >>
> >> >> CONFIG_XEN_INSTALL_SUFFIX :=
> >> >> diff --git a/config/arm64.mk b/config/arm64.mk
> >> >> index aa45772..861d0a4 100644
> >> >> --- a/config/arm64.mk
> >> >> +++ b/config/arm64.mk
> >> >> @@ -1,5 +1,6 @@
> >> >> CONFIG_ARM := y
> >> >> CONFIG_ARM_64 := y
> >> >> +CONFIG_VUART_CONSOLE := y
> >> >> CONFIG_ARM_$(XEN_OS) := y
> >> >
> >> > I think this wants to be solved better than by starting to again
> >> > introduce CONFIG_* values here.
> >>
> >> I think I can remove this flag from here since it is used currently
> >> for xenconsole only to enable VUART console support for ARM. I can
> >> directly define the flag in the tools/console Makefile based on
> >> CONFIG_ARM option.
> >
> > Just use CONFIG_ARM directly?
>
> I believe I cannot use CONFIG_ARM directly in
> tools/console/daemon/io.c as it is a makefile variable.
>
You should be able to. I think CONFIG_ARM/X86 are passed on to gcc.
And I just tested with CONFIG_X86, which worked.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-07 9:08 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 8:55 [PATCH 00/27 v8] SBSA UART emulation support in Xen Bhupinder Thakur
2017-08-28 8:55 ` [PATCH 01/27 v8] xen/arm: vpl011: Define common ring buffer helper functions in console.h Bhupinder Thakur
2017-08-28 8:55 ` [PATCH 02/27 v8] xen/arm: vpl011: Add SBSA UART emulation in Xen Bhupinder Thakur
2017-08-28 8:55 ` [PATCH 03/27 v8] xen/arm: vpl011: Allocate a new GFN in the toolstack for vuart Bhupinder Thakur
2017-08-28 8:55 ` [PATCH 04/27 v8] xen/arm: vpl011: Add support for vuart in libxl Bhupinder Thakur
2017-09-07 10:54 ` Andre Przywara
2017-08-28 8:55 ` [PATCH 05/27 v8] xen/arm: vpl011: Rearrange xen header includes in alphabetical order in domctl.c Bhupinder Thakur
2017-08-28 8:55 ` [PATCH 06/27 v8] xen/arm: vpl011: Add a new domctl API to initialize vpl011 Bhupinder Thakur
2017-08-28 9:09 ` Jan Beulich
2017-09-14 6:46 ` Bhupinder Thakur
2017-08-28 16:39 ` Wei Liu
2017-08-28 16:52 ` Wei Liu
2017-08-28 8:55 ` [PATCH 07/27 v8] xen/arm: vpl011: Add a new vuart node in the xenstore Bhupinder Thakur
2017-08-28 8:55 ` [PATCH 08/27 v8] xen/arm: vpl011: Modify xenconsole to define and use a new console structure Bhupinder Thakur
2017-08-28 8:55 ` [PATCH 09/27 v8] xen/arm: vpl011: Rename the console structure field conspath to xspath Bhupinder Thakur
2017-08-28 8:55 ` [PATCH 10/27 v8] xen/arm: vpl011: Modify xenconsole functions to take console structure as input Bhupinder Thakur
2017-08-28 8:55 ` [PATCH 11/27 v8] xen/arm: vpl011: Add a new console_init function in xenconsole Bhupinder Thakur
2017-08-28 16:40 ` Wei Liu
2017-08-28 8:55 ` [PATCH 12/27 v8] xen/arm: vpl011: Add a new buffer_available " Bhupinder Thakur
2017-08-28 8:55 ` [PATCH 13/27 v8] xen/arm: vpl011: Add a new maybe_add_console_evtchn_fd " Bhupinder Thakur
2017-08-28 8:55 ` [PATCH 14/27 v8] xen/arm: vpl011: Add a new maybe_add_console_tty_fd " Bhupinder Thakur
2017-08-28 8:55 ` [PATCH 15/27 v8] xen/arm: vpl011: Add a new console_evtchn_unmask " Bhupinder Thakur
2017-08-28 8:55 ` [PATCH 16/27 v8] xen/arm: vpl011: Add a new handle_console_ring " Bhupinder Thakur
2017-08-28 8:56 ` [PATCH 17/27 v8] xen/arm: vpl011: Add a new handle_console_tty " Bhupinder Thakur
2017-08-28 8:56 ` [PATCH 18/27 v8] xen/arm: vpl011: Add a new console_cleanup " Bhupinder Thakur
2017-08-28 8:56 ` [PATCH 19/27 v8] xen/arm: vpl011: Add a new console_open_log " Bhupinder Thakur
2017-08-28 8:56 ` [PATCH 20/27 v8] xen/arm: vpl011: Add a new console_close_evtchn " Bhupinder Thakur
2017-08-28 8:56 ` [PATCH 21/27 v8] xen/arm: vpl011: Add support for multiple consoles " Bhupinder Thakur
2017-08-28 16:50 ` Wei Liu
2017-08-28 8:56 ` [PATCH 22/27 v8] xen/arm: vpl011: Add support for vuart console " Bhupinder Thakur
2017-08-28 9:11 ` Jan Beulich
2017-09-04 16:28 ` Bhupinder Thakur
2017-09-05 5:29 ` Jan Beulich
2017-09-05 9:31 ` Wei Liu
2017-09-06 17:29 ` Bhupinder Thakur
2017-09-07 9:08 ` Wei Liu [this message]
2017-09-12 7:25 ` Bhupinder Thakur
2017-09-12 8:54 ` Wei Liu
2017-08-28 8:56 ` [PATCH 23/27 v8] xen/arm: vpl011: Add a new vuart console type to xenconsole client Bhupinder Thakur
2017-08-28 8:56 ` [PATCH 24/27 v8] xen/arm: vpl011: Add a pl011 uart DT node in the guest device tree Bhupinder Thakur
2017-08-28 8:56 ` [PATCH 25/27 v8] xen/arm: vpl011: Update documentation for vuart console support Bhupinder Thakur
2017-08-28 8:56 ` [PATCH 26/27 v8] xen/arm: vpl011: Correct the logic for asserting/de-asserting SBSA UART TX interrupt Bhupinder Thakur
2017-09-07 14:37 ` Andre Przywara
2017-09-11 16:39 ` Bhupinder Thakur
2017-09-12 14:35 ` Julien Grall
2017-09-12 14:58 ` Julien Grall
2017-08-28 8:56 ` [PATCH 27/27 v8] xen/arm: vpl011: Fix the slow early console SBSA UART output Bhupinder Thakur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907090841.rtm7cyidsfh7hx4k@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=bhupinder.thakur@linaro.org \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.