From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754933AbdIGKKf (ORCPT ); Thu, 7 Sep 2017 06:10:35 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:49510 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754882AbdIGKKa (ORCPT ); Thu, 7 Sep 2017 06:10:30 -0400 Date: Thu, 7 Sep 2017 11:10:17 +0100 From: Mark Brown To: Baolin Wang Cc: Baolin Wang , Rob Herring , Mark Rutland , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, LKML Subject: Re: [PATCH 2/2] spi: Add ADI driver for Spreadtrum platform Message-ID: <20170907101017.mcxfnm3u4osda7xr@sirena.co.uk> References: <20170906150446.v7qqc24wxeykcwwk@sirena.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ajr4hkh6p2f4q2l2" Content-Disposition: inline In-Reply-To: X-Cookie: Do unto others before they undo you. User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ajr4hkh6p2f4q2l2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 07, 2017 at 11:13:00AM +0800, Baolin Wang wrote: > >> +static int __init sprd_adi_init(void) > >> +{ > >> + return platform_driver_register(&sprd_adi_driver); > >> +} > >> +subsys_initcall(sprd_adi_init); > > Why is this subsys_initcall() and not module_platform_driver()? > Since ADI is one very fundamental driver for our SoC, many drivers > such as regulator need depend on ADI, and regulator need to regulate > core voltage as earlier as possible. That applies to huge numbers of systems - you should still just use regular init ordering in mainline, there are efforts to make things better there (look at Viresh's dependency stuff) so hopefully things will improve in the future and in the meantime the cost of probe deferral isn't *that* great and it's less fiddly than tweaking ordering. = =20 Practically speaking init ordering stuff can always be added in vendor kernels in the meantime. --ajr4hkh6p2f4q2l2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmxGwgACgkQJNaLcl1U h9ATxQf9GJyFelS5pv6enjgBsoy33K4irFW9v2DQM1v+ieuzCGjQlyebPrSiI1gi PM77w0tXGEBlm8yScNeW4E1CHg9fSx86Dg5X8tCW9fzal4L1AJa2GzgPpkKCwICN hpwUNsI3ujnRt2o5I/oLMkZt7Bbt/wHe0E4NwsvY6+fWj5BrxAR3dSBhMnjgphzz hTQeZVLz1JYNivizq8HU7qB8KjrJxeALJXN2wQ8FL2Js5rlqdiqIjZr3JpS804AR es291/huniQEmO4CuHl3k5obQGjgJKmaFQZkaVxe4iEHyWSHUinaYMWT/6aizr55 ZZQNFrMHlLWWlyO0XkwsiZYI+M4PoQ== =8Eox -----END PGP SIGNATURE----- --ajr4hkh6p2f4q2l2-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 2/2] spi: Add ADI driver for Spreadtrum platform Date: Thu, 7 Sep 2017 11:10:17 +0100 Message-ID: <20170907101017.mcxfnm3u4osda7xr@sirena.co.uk> References: <20170906150446.v7qqc24wxeykcwwk@sirena.co.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ajr4hkh6p2f4q2l2" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Baolin Wang Cc: Baolin Wang , Rob Herring , Mark Rutland , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML List-Id: devicetree@vger.kernel.org --ajr4hkh6p2f4q2l2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 07, 2017 at 11:13:00AM +0800, Baolin Wang wrote: > >> +static int __init sprd_adi_init(void) > >> +{ > >> + return platform_driver_register(&sprd_adi_driver); > >> +} > >> +subsys_initcall(sprd_adi_init); > > Why is this subsys_initcall() and not module_platform_driver()? > Since ADI is one very fundamental driver for our SoC, many drivers > such as regulator need depend on ADI, and regulator need to regulate > core voltage as earlier as possible. That applies to huge numbers of systems - you should still just use regular init ordering in mainline, there are efforts to make things better there (look at Viresh's dependency stuff) so hopefully things will improve in the future and in the meantime the cost of probe deferral isn't *that* great and it's less fiddly than tweaking ordering. = =20 Practically speaking init ordering stuff can always be added in vendor kernels in the meantime. --ajr4hkh6p2f4q2l2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmxGwgACgkQJNaLcl1U h9ATxQf9GJyFelS5pv6enjgBsoy33K4irFW9v2DQM1v+ieuzCGjQlyebPrSiI1gi PM77w0tXGEBlm8yScNeW4E1CHg9fSx86Dg5X8tCW9fzal4L1AJa2GzgPpkKCwICN hpwUNsI3ujnRt2o5I/oLMkZt7Bbt/wHe0E4NwsvY6+fWj5BrxAR3dSBhMnjgphzz hTQeZVLz1JYNivizq8HU7qB8KjrJxeALJXN2wQ8FL2Js5rlqdiqIjZr3JpS804AR es291/huniQEmO4CuHl3k5obQGjgJKmaFQZkaVxe4iEHyWSHUinaYMWT/6aizr55 ZZQNFrMHlLWWlyO0XkwsiZYI+M4PoQ== =8Eox -----END PGP SIGNATURE----- --ajr4hkh6p2f4q2l2-- -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html