All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org,
	Richard Henderson <richard.henderson@linaro.org>,
	borntraeger@de.ibm.com, Alexander Graf <agraf@suse.de>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 07/19] s390x: move two function declarations to s390-virtio-ccw.h
Date: Thu, 7 Sep 2017 15:23:37 +0200	[thread overview]
Message-ID: <20170907152337.02f7aec8.cohuck@redhat.com> (raw)
In-Reply-To: <09ff8ae8-3ad2-7dd3-16d9-0528c1ee665a@redhat.com>

On Thu, 7 Sep 2017 14:46:44 +0200
David Hildenbrand <david@redhat.com> wrote:

> >> +++ b/target/s390x/interrupt.c
> >> @@ -15,6 +15,9 @@
> >>  #include "exec/exec-all.h"
> >>  #include "sysemu/kvm.h"
> >>  #include "hw/s390x/ioinst.h"
> >> +#if !defined(CONFIG_USER_ONLY)
> >> +#include "hw/s390x/s390-virtio-ccw.h"
> >> +#endif
> >>  
> >>  /* Ensure to exit the TB after this call! */
> >>  void trigger_pgm_exception(CPUS390XState *env, uint32_t code, uint32_t ilen)
> >>  
> > 
> > If I listen to my gut feeling, I still think we should rather move
> > s390_cpu_addr2state() to cpu.c instead. It does not sound as it's really
> > specific to the virtio-ccw machine... Just my 0.02 €
> >   
> 
> I prefer to leave it as is for now, so just a header cleanup. E.g. with
> patch 18 we could implement it directly using ms->possible_cpus.

If you do that, would you also get rid of the conditional include above?

  reply	other threads:[~2017-09-07 13:23 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-04 15:42 [Qemu-devel] [PATCH v2 00/19] s390x cleanups and CPU hotplug via device_add David Hildenbrand
2017-09-04 15:42 ` [Qemu-devel] [PATCH v2 01/19] exec, dump, i386, ppc, s390x: don't include exec/cpu-all.h explicitly David Hildenbrand
2017-09-05 12:25   ` Cornelia Huck
2017-09-07  5:46   ` Thomas Huth
2017-09-07 12:41     ` David Hildenbrand
2017-09-07 13:11       ` Cornelia Huck
2017-09-04 15:42 ` [Qemu-devel] [PATCH v2 02/19] cpu: drop old comments describing members David Hildenbrand
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 03/19] s390x: get rid of s390-virtio.c David Hildenbrand
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 04/19] s390x: rename s390-virtio.h to s390-virtio-hcall.h David Hildenbrand
2017-09-05  8:54   ` Christian Borntraeger
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 05/19] target/s390x: move typedef of S390CPU to its definition David Hildenbrand
2017-09-05 12:34   ` Cornelia Huck
2017-09-07  5:50   ` Thomas Huth
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 06/19] s390x: move s390_virtio_hypercall() to s390-virtio-hcall.h David Hildenbrand
2017-09-07  5:56   ` Thomas Huth
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 07/19] s390x: move two function declarations to s390-virtio-ccw.h David Hildenbrand
2017-09-07  6:04   ` Thomas Huth
2017-09-07 12:46     ` David Hildenbrand
2017-09-07 13:23       ` Cornelia Huck [this message]
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to interrupt.c David Hildenbrand
2017-09-05 12:38   ` Cornelia Huck
2017-09-05 12:42     ` David Hildenbrand
2017-09-05 12:46       ` Christian Borntraeger
2017-09-05 12:52         ` Thomas Huth
2017-09-05 12:55           ` Cornelia Huck
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 09/19] target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault() David Hildenbrand
2017-09-07  5:59   ` Thomas Huth
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 10/19] target/s390x: use program_interrupt() in per_check_exception() David Hildenbrand
2017-09-07 13:32   ` Cornelia Huck
2017-09-07 13:52     ` David Hildenbrand
2017-09-07 16:55       ` Cornelia Huck
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG David Hildenbrand
2017-09-06 18:16   ` Matthew Rosato
2017-09-06 21:20     ` Richard Henderson
2017-09-07 12:49       ` David Hildenbrand
2017-09-07 12:51         ` Cornelia Huck
2017-09-14 18:13       ` David Hildenbrand
2017-09-15  7:38         ` Cornelia Huck
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 12/19] target/s390x: set cpu->id for linux user when realizing David Hildenbrand
2017-09-07  1:42   ` Matthew Rosato
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 13/19] target/s390x: use "core-id" for cpu number/address/id handling David Hildenbrand
2017-09-07  3:15   ` Matthew Rosato
2017-09-07 13:02     ` David Hildenbrand
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 14/19] target/s390x: rename next_cpu_id to next_core_id David Hildenbrand
2017-09-07  3:15   ` Matthew Rosato
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 15/19] s390x: print CPU definitions in sorted order David Hildenbrand
2017-09-07 15:22   ` Cornelia Huck
2017-09-07 20:04     ` David Hildenbrand
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 16/19] s390x: allow cpu hotplug via device_add David Hildenbrand
2017-09-07  3:16   ` Matthew Rosato
2017-09-07 13:04     ` David Hildenbrand
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via device_del cannot work David Hildenbrand
2017-09-05  9:14   ` Christian Borntraeger
2017-09-05 12:01     ` David Hildenbrand
2017-09-05 12:14       ` Christian Borntraeger
2017-09-05 12:54         ` Cornelia Huck
2017-09-05 13:09           ` Christian Borntraeger
2017-09-06 18:13   ` Matthew Rosato
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 18/19] s390x: implement query-hotpluggable-cpus David Hildenbrand
2017-09-07 17:05   ` Cornelia Huck
2017-09-04 15:43 ` [Qemu-devel] [PATCH v2 19/19] s390x: get rid of cpu_s390x_create() David Hildenbrand
2017-09-07 17:11   ` Cornelia Huck
2017-09-05  7:51 ` [Qemu-devel] [PATCH v2 00/19] s390x cleanups and CPU hotplug via device_add Christian Borntraeger
2017-09-06 16:03   ` David Hildenbrand
2017-09-06 16:21     ` Matthew Rosato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170907152337.02f7aec8.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=david@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.