From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dq0Ld-0000mr-DM for qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:12:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dq0LY-0008TB-Le for qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:12:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6168) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dq0LY-0008Sf-FR for qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:12:08 -0400 Date: Thu, 7 Sep 2017 19:11:59 +0200 From: Cornelia Huck Message-ID: <20170907191159.767509da.cohuck@redhat.com> In-Reply-To: <20170904154316.4148-20-david@redhat.com> References: <20170904154316.4148-1-david@redhat.com> <20170904154316.4148-20-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 19/19] s390x: get rid of cpu_s390x_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: qemu-devel@nongnu.org, Richard Henderson , thuth@redhat.com, borntraeger@de.ibm.com, Alexander Graf , Eduardo Habkost On Mon, 4 Sep 2017 17:43:16 +0200 David Hildenbrand wrote: > Now that there is only one user of cpu_s390x_create() left, make cpu > creation looks like on x86. > - Perform the model/properties split and checks in s390_init_cpus() > - Parse features only once without having to remember if already parsed > - Pass only the typename to s390x_new_cpu() > - Use the typename of an existing CPU for hotplug via cpu-add > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 29 +++++++++++++++++++++++++++-- > target/s390x/cpu.h | 2 +- > target/s390x/helper.c | 45 ++------------------------------------------- > target/s390x/internal.h | 1 - > 4 files changed, 30 insertions(+), 47 deletions(-) LGTM