From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932582AbdIGUJP (ORCPT ); Thu, 7 Sep 2017 16:09:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:43908 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932378AbdIGUJN (ORCPT ); Thu, 7 Sep 2017 16:09:13 -0400 Date: Thu, 7 Sep 2017 22:09:00 +0200 From: Borislav Petkov To: Nicolas Iooss Cc: Ingo Molnar , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] RAS/CEC: use the right length of "cec_disable" Message-ID: <20170907200900.wzrtp52jwpyxucce@pd.tnic> References: <20170903075440.30250-1-nicolas.iooss_linux@m4x.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170903075440.30250-1-nicolas.iooss_linux@m4x.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 03, 2017 at 09:54:40AM +0200, Nicolas Iooss wrote: > parse_cec_param() compares a string with "cec_disable" using only 7 > characters of the 11-character-long string. Fix the length. > > Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector") > Signed-off-by: Nicolas Iooss > --- > drivers/ras/cec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c > index d0e5d6ee882c..586c296d1538 100644 > --- a/drivers/ras/cec.c > +++ b/drivers/ras/cec.c > @@ -523,7 +523,7 @@ int __init parse_cec_param(char *str) > if (*str == '=') > str++; > > - if (!strncmp(str, "cec_disable", 7)) > + if (!strncmp(str, "cec_disable", 11)) > ce_arr.disabled = 1; > else > return 0; > -- Applied, thanks. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --