From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stafford Horne Subject: Re: [PATCH] openrisc: add forward declaration for struct vm_area_struct Date: Sat, 9 Sep 2017 00:29:11 +0900 Message-ID: <20170908152911.GQ2609@lianli.shorne-pla.net> References: <201709080345.bk1IOlp7%fengguang.wu@intel.com> <20170908082508.14325-1-tklauser@distanz.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:34580 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755916AbdIHP3O (ORCPT ); Fri, 8 Sep 2017 11:29:14 -0400 Received: by mail-pf0-f193.google.com with SMTP id g65so1345988pfe.1 for ; Fri, 08 Sep 2017 08:29:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170908082508.14325-1-tklauser@distanz.ch> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Tobias Klauser Cc: Jonas Bonn , Stefan Kristiansson , Arnd Bergmann , openrisc@lists.librecores.org, linux-arch@vger.kernel.org, kbuild-all@01.org, kbuild test robot On Fri, Sep 08, 2017 at 10:25:08AM +0200, Tobias Klauser wrote: > After removing linux/vmalloc.h from asm-generic/io.h, the following > warning occurs on openrisc: > > In file included from arch/openrisc/include/asm/io.h:33:0, > from include/linux/io.h:25, > from drivers/tty/serial/earlycon.c:19: > arch/openrisc/include/asm/pgtable.h:424:2: warning: 'struct vm_area_struct' declared inside parameter list > unsigned long address, pte_t *pte) > ^ [..] > @@ -414,6 +414,8 @@ static inline void pmd_set(pmd_t *pmdp, pte_t *ptep) > > extern pgd_t swapper_pg_dir[PTRS_PER_PGD]; /* defined in head.S */ > > +struct vm_area_struct; > + Acked-by: Stafford Horne I was kind of wondering whether is better to include linux/mm_types.h or linux/vmalloc.h here instead of the forward declaration. But looking at how other architectures do it; about half do the forward declaration, and half use an include. So I guess this is fine. I noticed you were getting a lot of these patches done for removing linux/vmalloc.h from asm-generic/io.h. Do you want me to push this through my queue or are you planning sending them through another route? -Stafford From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stafford Horne Date: Sat, 9 Sep 2017 00:29:11 +0900 Subject: [OpenRISC] [PATCH] openrisc: add forward declaration for struct vm_area_struct In-Reply-To: <20170908082508.14325-1-tklauser@distanz.ch> References: <201709080345.bk1IOlp7%fengguang.wu@intel.com> <20170908082508.14325-1-tklauser@distanz.ch> Message-ID: <20170908152911.GQ2609@lianli.shorne-pla.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org On Fri, Sep 08, 2017 at 10:25:08AM +0200, Tobias Klauser wrote: > After removing linux/vmalloc.h from asm-generic/io.h, the following > warning occurs on openrisc: > > In file included from arch/openrisc/include/asm/io.h:33:0, > from include/linux/io.h:25, > from drivers/tty/serial/earlycon.c:19: > arch/openrisc/include/asm/pgtable.h:424:2: warning: 'struct vm_area_struct' declared inside parameter list > unsigned long address, pte_t *pte) > ^ [..] > @@ -414,6 +414,8 @@ static inline void pmd_set(pmd_t *pmdp, pte_t *ptep) > > extern pgd_t swapper_pg_dir[PTRS_PER_PGD]; /* defined in head.S */ > > +struct vm_area_struct; > + Acked-by: Stafford Horne I was kind of wondering whether is better to include linux/mm_types.h or linux/vmalloc.h here instead of the forward declaration. But looking at how other architectures do it; about half do the forward declaration, and half use an include. So I guess this is fine. I noticed you were getting a lot of these patches done for removing linux/vmalloc.h from asm-generic/io.h. Do you want me to push this through my queue or are you planning sending them through another route? -Stafford