From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 11 Sep 2017 13:57:46 +0800 From: Shawn Guo To: "A.s. Dong" Cc: Michael Turquette , Shawn Guo , Stephen Boyd , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] clk: bulk: call of_clk_get() when id is NULL Message-ID: <20170911055745.GF3787@dragon> References: <1502243442-28055-1-git-send-email-shawnguo@kernel.org> <20170809173318.GD2146@codeaurora.org> <20170813141851.GD31819@dragon> <20170831052630.GU21656@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On Mon, Sep 11, 2017 at 04:51:28AM +0000, A.s. Dong wrote: > Hi Shawn, > > > -----Original Message----- > > From: Stephen Boyd [mailto:sboyd@codeaurora.org] > > Sent: Thursday, August 31, 2017 1:27 PM > > To: A.s. Dong > > Cc: Shawn Guo; Michael Turquette; linux-clk@vger.kernel.org; linux-arm- > > kernel@lists.infradead.org; Shawn Guo > > Subject: Re: [PATCH] clk: bulk: call of_clk_get() when id is NULL > > > > On 08/30, A.s. Dong wrote: > > [...] > > > > Flags may be better used for extending per clk feature support in the > > future. > > > > > > IMHO how about implement a of_clk_bulk_get() to handle this issue as > > > we already have a of_clk_get? > > > e.g. > > > > > > int __must_check of_clk_bulk_get(struct device_node *np, int num_clks, > > > struct clk_bulk_data *clks) { > > > for (i = 0; i < num_clks; i++) { > > > clks[i].clk = of_clk_get(dev, clks[i].id); ... > > > > > > } > > > > > > Then it's less intrusive. > > > > > > > This looks ok too. Go ahead and send this version instead. > > > > I did not see you send a update version. > If you will not do it, would you mind me to help send it with a Reported-by: tag from you? Sure, go ahead. Shawn From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawnguo@kernel.org (Shawn Guo) Date: Mon, 11 Sep 2017 13:57:46 +0800 Subject: [PATCH] clk: bulk: call of_clk_get() when id is NULL In-Reply-To: References: <1502243442-28055-1-git-send-email-shawnguo@kernel.org> <20170809173318.GD2146@codeaurora.org> <20170813141851.GD31819@dragon> <20170831052630.GU21656@codeaurora.org> Message-ID: <20170911055745.GF3787@dragon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Sep 11, 2017 at 04:51:28AM +0000, A.s. Dong wrote: > Hi Shawn, > > > -----Original Message----- > > From: Stephen Boyd [mailto:sboyd at codeaurora.org] > > Sent: Thursday, August 31, 2017 1:27 PM > > To: A.s. Dong > > Cc: Shawn Guo; Michael Turquette; linux-clk at vger.kernel.org; linux-arm- > > kernel at lists.infradead.org; Shawn Guo > > Subject: Re: [PATCH] clk: bulk: call of_clk_get() when id is NULL > > > > On 08/30, A.s. Dong wrote: > > [...] > > > > Flags may be better used for extending per clk feature support in the > > future. > > > > > > IMHO how about implement a of_clk_bulk_get() to handle this issue as > > > we already have a of_clk_get? > > > e.g. > > > > > > int __must_check of_clk_bulk_get(struct device_node *np, int num_clks, > > > struct clk_bulk_data *clks) { > > > for (i = 0; i < num_clks; i++) { > > > clks[i].clk = of_clk_get(dev, clks[i].id); ... > > > > > > } > > > > > > Then it's less intrusive. > > > > > > > This looks ok too. Go ahead and send this version instead. > > > > I did not see you send a update version. > If you will not do it, would you mind me to help send it with a Reported-by: tag from you? Sure, go ahead. Shawn