All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libmbim: fix build with musl libc
Date: Mon, 11 Sep 2017 11:27:09 +0300	[thread overview]
Message-ID: <20170911082709.gwkfnhg37krcynjn@sapphire.tkos.co.il> (raw)
In-Reply-To: <20170911075426.514-1-aleksander@aleksander.es>

Hi Aleksander,

On Mon, Sep 11, 2017 at 09:54:26AM +0200, Aleksander Morgado wrote:
> This is now failing because the libgudev dependency is optional and
> the build will only use if it's found during the configure checks.
> 
> Imported the same patch that has been applied in the upstream libmbim
> git repository:
>   https://cgit.freedesktop.org/libmbim/libmbim/commit/?id=417b0b80023dc30d61c111ec0a54da2884d3a541
> 
> Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> ---
>  ...-prefer-realpath-to-canonicalize_file_nam.patch | 36 ++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644 package/libmbim/0001-mbim-device-prefer-realpath-to-canonicalize_file_nam.patch
> 
> diff --git a/package/libmbim/0001-mbim-device-prefer-realpath-to-canonicalize_file_nam.patch b/package/libmbim/0001-mbim-device-prefer-realpath-to-canonicalize_file_nam.patch
> new file mode 100644
> index 000000000..a13aee547
> --- /dev/null
> +++ b/package/libmbim/0001-mbim-device-prefer-realpath-to-canonicalize_file_nam.patch
> @@ -0,0 +1,36 @@
> +From 48772b32f10523cca22b7d63c3523377279c7427 Mon Sep 17 00:00:00 2001
> +From: Aleksander Morgado <aleksander@aleksander.es>
> +Date: Mon, 11 Sep 2017 09:31:03 +0200
> +Subject: [PATCH] mbim-device: prefer realpath() to canonicalize_file_name()
> +
> +Usually the canonicalize_file_name() GNU extension is preferred to the
> +POSIX realpath(), as it covers some of the limitations the latter has.
> +But this extension isn't available in lots of platforms or in other
> +c library implementations (e.g. musl), so just default to the POSIX
> +method to improve portability.
> +
> +Note that the check for canonicalize_file_name() availability during
> +configure isn't as trivial as adding a new AC_CHECK_FUNCS(), and
> +importing a gnulib module seems overkill just for this one liner.
> +
> +(cherry picked from commit 417b0b80023dc30d61c111ec0a54da2884d3a541)

Please add your sign-off here.

baruch

> +---
> + src/libmbim-glib/mbim-device.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/src/libmbim-glib/mbim-device.c b/src/libmbim-glib/mbim-device.c
> +index e1f32a6..20e64af 100644
> +--- a/src/libmbim-glib/mbim-device.c
> ++++ b/src/libmbim-glib/mbim-device.c
> +@@ -867,7 +867,7 @@ get_descriptors_filepath (MbimDevice *self)
> +          *    /sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.5/2-1.5:2.0
> +          */
> +         tmp = g_strdup_printf ("/sys/class/%s/%s/device", subsystems[i], device_basename);
> +-        path = canonicalize_file_name (tmp);
> ++        path = realpath (tmp, NULL);
> +         g_free (tmp);
> + 
> +         if (g_file_test (path, G_FILE_TEST_EXISTS)) {

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2017-09-11  8:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11  7:54 [Buildroot] [PATCH] libmbim: fix build with musl libc Aleksander Morgado
2017-09-11  8:27 ` Baruch Siach [this message]
2017-09-11  8:55 ` [Buildroot] [PATCH v2] " Aleksander Morgado
2017-09-23 20:25   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170911082709.gwkfnhg37krcynjn@sapphire.tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.