From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751305AbdIKTsM (ORCPT <rfc822;w@1wt.eu>);
        Mon, 11 Sep 2017 15:48:12 -0400
Received: from mail-pg0-f44.google.com ([74.125.83.44]:34134 "EHLO
        mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750782AbdIKTsL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 11 Sep 2017 15:48:11 -0400
X-Google-Smtp-Source: ADKCNb7/9SIX2tOe4QIdMT6MH/im7cneBiFMM/8JSSHdNGKYAXHtuofVIdPcpgLteetDGeZaTlxO1g==
Date: Mon, 11 Sep 2017 12:48:07 -0700
From: Benson Leung <bleung@google.com>
To: Brian Norris <briannorris@chromium.org>
Cc: Olof Johansson <olof@lixom.net>, Benson Leung <bleung@chromium.org>,
        Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org,
        Doug Anderson <dianders@chromium.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        Shawn Nematbakhsh <shawnn@chromium.org>,
        Gwendal Grignou <gwendal@chromium.org>,
        Enric Balletbo <enric.balletbo@collabora.co.uk>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: Re: [PATCH v3] platform/chrome: Use proper protocol transfer function
Message-ID: <20170911194807.GA41615@decatoncale.mtv.corp.google.com>
References: <20170908205011.77986-1-briannorris@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR"
Content-Disposition: inline
In-Reply-To: <20170908205011.77986-1-briannorris@chromium.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--T4sUOijqQbZv57TR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Brian,

On Fri, Sep 08, 2017 at 01:50:11PM -0700, Brian Norris wrote:
> From: Shawn Nematbakhsh <shawnn@chromium.org>
>=20
> pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had
> one instance of these functions correct, but not the second, fall-back
> case. We use the fall-back only when the first command returns an
> IN_PROGRESS status, which is only used on some EC firmwares where we
> don't want to constantly poll the bus, but instead back off and
> sleep/retry for a little while.
>=20
> Fixes: 2c7589af3c4d ("mfd: cros_ec: add proto v3 skeleton")
> Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Looks good. Applied for v4.14.

Thanks!
Benson

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--T4sUOijqQbZv57TR
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJZtuh2AAoJEB8J9XsKL+ZYl1EP/j87OsxNgRD4hzxuJzBC65Ax
m8bNOr5xO061LuiJfdhY8AxVLyBkS5JqeAWLsdxxYvfv8X30Ua9AexWWRt74266d
KXM6LzzMgW6OKCB0yg8RTyivIE+VcG9IUIKAIMWHesfPjbiw9vegI8kTbxon2ixv
qeqApU+6xNd9nsFwu2O7fP03oI/Ysfn2LnYirBusB2TU5jnfwd3lyKVVT2t7xfPL
C+B0aaEsNArmrS6XvsxYGPo8UpqtLvcnN41ClZnjPlHDmz45o8Izpi8MndN8mKgW
MXrB22cYIDC79vfWBdsZ+1A9tkvbkqr1180iMY0oozIYoVbk0vBAxXCeCSarKijq
pVxwi5rPdUsrbXcEra80OgEFiXXlJQVsa6+FuE/2WByQVUm+qF1GZ0lca6njtYm8
l+RCRt70yRIPo9xSTVihY3imXp5GENC0i0PQ4sBDdZ4p29VPNafV+OsxqxlA+8Xv
Am67GALsWjtkDTrqTAztfpmpzsAZ1uXAd0nh0yexUQWE7RNXn5NGi0q8MdkcvDwA
yrDO+3RnlJe2Bejt41aanls5mNROTukwxaHsWVifwHJ7c19zhqUOM1lXDtz0fSNa
sA5Agz/PiQ3tFQeEH00T0UViE0HEosmTxQPzSFQ6Mv4imX/Q6/6uk/0NQajUjYWj
6mYb8Z4AaOzCDwNQRh7c
=cPFT
-----END PGP SIGNATURE-----

--T4sUOijqQbZv57TR--