From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751243AbdIKUME (ORCPT ); Mon, 11 Sep 2017 16:12:04 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:49390 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbdIKUMD (ORCPT ); Mon, 11 Sep 2017 16:12:03 -0400 From: Arnd Bergmann To: Andrew Morton Cc: Arnd Bergmann , Russell King , linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] [RESEND] pcmcia: badge4: avoid unused function warning Date: Mon, 11 Sep 2017 22:11:15 +0200 Message-Id: <20170911201133.3421636-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:Hp65ty8IBi7S9zs8YPWFgtO4xk1sqELPAU5CFSGyuyonWrvubXz wP3Ns5Rd9fXaiXvWxI0YKDrOGo1wjxVWdegi+GYXYf+iVdU2gRG71SiJ4lxFEdxnpzbsz+T 8kDa5hjcum0Odw9el6KPy1M3Zm6RoDS9lfr8X9qbqmzBrA+f3AhSJZCPoCI8/Xpv0HZdKsQ qmEYQsYy4Tg3tdy7znXUg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Paw4JVNVhKw=:FoZBVBijiNZftxLl/bPU1b 8fv44boyIvs/bRX7AkYocGd+QmFzTK8XlG914htkkC5iinDXgPT8DG1L6Nn/B4k/Rpk6FLme1 zTRu1NjxJWvnWWNSM2tm1zesHyH1my7rrk0rnts/gy4zNP0r2Q3knPYR+gJUm7WmifpN1Lt7B V143afjeKf6JCPRNy1SGk9YQtpyRiOap7Pa2AUGUwuqzWaN7IIAXd1MZLu4gEiEAPMABnhY1g Pt+hJwHJG7VM0+OlVjEumtmdTiiTEVQjMEW3cSId1Txk2r2Y8JKzfTGBCAbl/hX2haQA5C/LG Ncx18dzqNgh5zOOOp2EC64cvt68WKgWx4/OjIYoqYqL8rBTLRPGhKSkerSgkA6dJJjHmjNEr0 rk5UmAnMCqfV8EwJjkVstynlFQGsGXkk08L0r/dsEj86eHRe81p5/QgqgjQ4FatX1qYxp22S8 1oyqIqRq+sxGq5gOpU/si5ZojYXrELA6rhtevmV9ZsRbac3nMQ4KwfbJkmIYWGFQ0jHrftd9V 1hiWDBaWkooVEaml49XTBy2c1Xw2zmzks1kZWSN/g4RneOziCZavsbScqVBVtSUx04AN7wu9I ArBG81UUGGoitQbbEIJWjgXB/1+CLVdubs32iZtbzsr7PTlAdP08DLOgexcpzfcaA3i7fWyrC wxlRfKRth6iuVkHIW7tp/u2kYu+a60E9Al+bIgi5wIyMPs0wOne5oRDO20quHhpH+2oA71zhs +OoJGiR/Z+NQ8sqCTqTVW3dR3CXynHI2eBaxJA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The pcmv_setup is only used when the badge4 driver is built-in, but not when it is a loadable module: drivers/pcmcia/sa1111_badge4.c:153:122: error: 'pcmv_setup' defined but not used [-Werror=unused-function] This adds an #ifdef to avoid the definition of the unused function in the modular case. Signed-off-by: Arnd Bergmann --- Patch was sent on Jan 25 2016, and on July 21, 2017 but got no reply. Andrew, could you pick it up? --- drivers/pcmcia/sa1111_badge4.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pcmcia/sa1111_badge4.c b/drivers/pcmcia/sa1111_badge4.c index 2f490930430d..93a5c7423d80 100644 --- a/drivers/pcmcia/sa1111_badge4.c +++ b/drivers/pcmcia/sa1111_badge4.c @@ -144,6 +144,7 @@ int pcmcia_badge4_init(struct sa1111_dev *dev) sa11xx_drv_pcmcia_add_one); } +#ifndef MODULE static int __init pcmv_setup(char *s) { int v[4]; @@ -158,3 +159,4 @@ static int __init pcmv_setup(char *s) } __setup("pcmv=", pcmv_setup); +#endif -- 2.9.0