From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: git trees organization
Date: Wed, 13 Sep 2017 09:58:45 +0200
Message-ID: <20170913075845.GR2481@6wind.com>
References: <2737351.pD9poAUtZC@xps>
 <20170912083207.GC40060@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Thomas Monjalon <thomas@monjalon.net>, ferruh.yigit@intel.com,
 stephen@networkplumber.org, dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id 620267CB6
 for <dev@dpdk.org>; Wed, 13 Sep 2017 09:58:57 +0200 (CEST)
Received: by mail-wm0-f53.google.com with SMTP id i189so10606800wmf.1
 for <dev@dpdk.org>; Wed, 13 Sep 2017 00:58:57 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20170912083207.GC40060@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

On Tue, Sep 12, 2017 at 09:32:07AM +0100, Bruce Richardson wrote:
> On Tue, Sep 12, 2017 at 12:03:30AM +0200, Thomas Monjalon wrote:
> > Hi all,
> > 
> > As you know I am currently the only maintainer of the master tree.
> > It is very convenient because I need to synchronize with others
> > only when pulling "next-*" trees.
> > But the drawback is that I should be available very often to
> > avoid stalled patches waiting in patchwork backlog.
> > 
> > I feel it is the good time to move to a slightly different organization.
> > I am working closely with Ferruh Yigit for almost one year, as next-net
> > maintainer, and I think it would be very efficient to delegate him some
> > work for the master tree.
> 
> I think Ferruh has been doing an excellent job on the net tree, and
> would be an excellent candidate to help with the workload on the master
> tree.
> 
> > I mean that I would use the patchwork delegation to explicitly divide
> > the workload given our different experiences.
> > Ferruh, do you agree taking this new responsibility?
> > 
> > At the same time, we can think how to add more git sub-trees:
> 
> In principle, I'm in favour, but I think that the subtrees of the master
> tree should be at a fairly coarse granularity, and not be too many of
> them. The more subtrees, the more likely we are to have issues with
> patchsets needing to be split across trees, or having to take bits from
> multiple trees in order to test if everything is working.
<snip>

About that, how about we start allowing true merge commits instead of
rebasing (rewriting history) in order to ease things for maintainers?

This approach makes pull requests show up as a merge commits that contain
the (ideally trivial) changes needed to resolve any conflicts; this has the
following benefits:

- The work done by a maintainer during that merge is tracked, not silently
  ignored or lost. The merge commit itself is signed-off by its author.

- This allows tracing mistakes or bugs to the conflict resolution itself.

- Upstream can reject pull requests on the basis that merging it is not
  trivial enough (i.e. downstream must merge upstream changes first).

- Sub-trees can merge among themselves in case they need features that
  encompass several trees, not necessarily always against the master
  tree. Everything is tracked.

- Maintainers do not ever modify the commits they get from other trees,
  which keep their SHAs unmodified as part of the history. A given commit ID
  is truly unique among all trees (back-port trees remain the only exception
  since commits are cherry-picked).

- It shifts the entire responsibility to the maintainers of sub-trees.

The only downside is that commits have several parents, history becomes a
graph that developers need to get used to (some might call it a mess),
however that's probably not an issue for those already used to Linux kernel
development and other large projects.

I know this was already discussed in the past, however I think adding more
sub-trees will make rebasing too complex otherwise.

Thoughts?

-- 
Adrien Mazarguil
6WIND