From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ds4kg-0001EV-78 for qemu-devel@nongnu.org; Wed, 13 Sep 2017 06:18:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ds4kf-0001Hs-0f for qemu-devel@nongnu.org; Wed, 13 Sep 2017 06:18:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35130) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ds4ke-0001HC-R8 for qemu-devel@nongnu.org; Wed, 13 Sep 2017 06:18:36 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BA41F806AC for ; Wed, 13 Sep 2017 10:18:35 +0000 (UTC) Date: Wed, 13 Sep 2017 11:18:27 +0100 From: "Daniel P. Berrange" Message-ID: <20170913101827.GB3067@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170808162629.32493-1-quintela@redhat.com> <20170808162629.32493-8-quintela@redhat.com> <20170811145601.GP2554@redhat.com> <87d16uewko.fsf@secure.laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87d16uewko.fsf@secure.laptop> Subject: Re: [Qemu-devel] [PATCH v6 07/19] migration: Create x-multifd-threads parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com On Wed, Sep 13, 2017 at 12:12:39PM +0200, Juan Quintela wrote: > "Daniel P. Berrange" wrote: > > On Tue, Aug 08, 2017 at 06:26:17PM +0200, Juan Quintela wrote: > >> Indicates the number of threads that we would create. By default we > >> create 2 threads. > >> # migrated and the destination must already have access to the > >> # same backing chain as was used on the source. (since 2.10) > >> # > >> +# @x-multifd-threads: Number of threads used to migrate data in > >> +# parallel. This is the same number that the > >> +# number of sockets used for migration. > >> +# The default value is 2 (since 2.11) > > > > The feature is called "multifd" but we're configuring number of threads, > > with the implicit suggestion that number of threads == number of sockets. > > > > I wonder if its better to call this "x-multifd-connections" so that it > > is explicit that we're determining the number of socket connections. > > > > This leaves room for adapting code to use a different number of threads, > > but same number of sockets. eg with post-copy, there's potential to have > > 2 threads for each socket (1 reading, 1 writing). > > Changed to channels, is that ok for you? Sure Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|