From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752436AbdIMPVU (ORCPT ); Wed, 13 Sep 2017 11:21:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:52490 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751123AbdIMPVS (ORCPT ); Wed, 13 Sep 2017 11:21:18 -0400 Date: Wed, 13 Sep 2017 17:21:06 +0200 From: Borislav Petkov To: Brijesh Singh Cc: linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, Thomas Gleixner , Joerg Roedel , "Michael S . Tsirkin" , Paolo Bonzini , =?utf-8?B?XCJSYWRpbSBLcsSNbcOhxZlcIg==?= , Tom Lendacky Subject: Re: [RFC Part2 PATCH v3 11/26] KVM: X86: Extend struct kvm_arch to include SEV information Message-ID: <20170913152106.lnraiqehjnj5zll6@pd.tnic> References: <20170724200303.12197-1-brijesh.singh@amd.com> <20170724200303.12197-12-brijesh.singh@amd.com> <20170913133729.dtae2a3kidoigri5@pd.tnic> <2a5702c8-a60a-7836-6eec-891a3c3e8ace@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2a5702c8-a60a-7836-6eec-891a3c3e8ace@amd.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 13, 2017 at 10:14:20AM -0500, Brijesh Singh wrote: > Actually, I see both approaches used in svm.c but I am flexible to go with > either ways. lets wait for Paolo and Radim comments. Frankly, if you're going to access those fields only in svm.c, those accessors look like an overkill to me. But maybe there's a higher strategy behind it... -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --