From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751583AbdIMRD2 (ORCPT ); Wed, 13 Sep 2017 13:03:28 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:50351 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751458AbdIMRDT (ORCPT ); Wed, 13 Sep 2017 13:03:19 -0400 Date: Wed, 13 Sep 2017 19:03:10 +0200 From: Alexandre Belloni To: Nicolas Ferre Cc: Romain Izard , Boris Brezillon , Michael Turquette , Stephen Boyd , Ludovic Desroches , Jonathan Cameron , Wenyou Yang , Josh Wu , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , Thierry Reding , Richard Genoud , Greg Kroah-Hartman , Alan Stern , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mtd@lists.infradead.org, linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Romain Izard Subject: Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable clocks Message-ID: <20170913170310.grfv7j5xvh7chjdo@piout.net> References: <20170908153604.28383-1-romain.izard.pro@gmail.com> <20170908153604.28383-4-romain.izard.pro@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/09/2017 at 14:29:35 +0200, Nicolas Ferre wrote: > On 08/09/2017 at 17:35, Romain Izard wrote: > > From: Romain Izard > > > > Save and restore the System Clock and Programmable Clock register for > > the backup use case. > > "System Clock" seems to be handled in another patch. > > > Signed-off-by: Romain Izard > > --- > > drivers/clk/at91/pmc.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c > > index 07dc2861ad3f..5421b03553ec 100644 > > --- a/drivers/clk/at91/pmc.c > > +++ b/drivers/clk/at91/pmc.c > > @@ -66,6 +66,7 @@ static struct > > u32 pcr[PMC_MAX_IDS]; > > u32 audio_pll0; > > u32 audio_pll1; > > + u32 pckr[3]; > > Some products have different numbers of PCK (only 2 on at91sam9x5 for > instance)... > My opinion is that it will be time to change that when multiple SoCs will need to save their registers. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable clocks Date: Wed, 13 Sep 2017 19:03:10 +0200 Message-ID: <20170913170310.grfv7j5xvh7chjdo@piout.net> References: <20170908153604.28383-1-romain.izard.pro@gmail.com> <20170908153604.28383-4-romain.izard.pro@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Nicolas Ferre Cc: Romain Izard , Boris Brezillon , Michael Turquette , Stephen Boyd , Ludovic Desroches , Jonathan Cameron , Wenyou Yang , Josh Wu , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , Thierry Reding , Richard Genoud , Greg Kroah-Hartman , Alan Stern , linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TZNg+MwTxZMZA@public.gmane.org List-Id: linux-pwm@vger.kernel.org On 13/09/2017 at 14:29:35 +0200, Nicolas Ferre wrote: > On 08/09/2017 at 17:35, Romain Izard wrote: > > From: Romain Izard > > > > Save and restore the System Clock and Programmable Clock register for > > the backup use case. > > "System Clock" seems to be handled in another patch. > > > Signed-off-by: Romain Izard > > --- > > drivers/clk/at91/pmc.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c > > index 07dc2861ad3f..5421b03553ec 100644 > > --- a/drivers/clk/at91/pmc.c > > +++ b/drivers/clk/at91/pmc.c > > @@ -66,6 +66,7 @@ static struct > > u32 pcr[PMC_MAX_IDS]; > > u32 audio_pll0; > > u32 audio_pll1; > > + u32 pckr[3]; > > Some products have different numbers of PCK (only 2 on at91sam9x5 for > instance)... > My opinion is that it will be time to change that when multiple SoCs will need to save their registers. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Wed, 13 Sep 2017 19:03:10 +0200 Subject: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable clocks In-Reply-To: References: <20170908153604.28383-1-romain.izard.pro@gmail.com> <20170908153604.28383-4-romain.izard.pro@gmail.com> Message-ID: <20170913170310.grfv7j5xvh7chjdo@piout.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 13/09/2017 at 14:29:35 +0200, Nicolas Ferre wrote: > On 08/09/2017 at 17:35, Romain Izard wrote: > > From: Romain Izard > > > > Save and restore the System Clock and Programmable Clock register for > > the backup use case. > > "System Clock" seems to be handled in another patch. > > > Signed-off-by: Romain Izard > > --- > > drivers/clk/at91/pmc.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c > > index 07dc2861ad3f..5421b03553ec 100644 > > --- a/drivers/clk/at91/pmc.c > > +++ b/drivers/clk/at91/pmc.c > > @@ -66,6 +66,7 @@ static struct > > u32 pcr[PMC_MAX_IDS]; > > u32 audio_pll0; > > u32 audio_pll1; > > + u32 pckr[3]; > > Some products have different numbers of PCK (only 2 on at91sam9x5 for > instance)... > My opinion is that it will be time to change that when multiple SoCs will need to save their registers. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com