From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Subject: Re: [PATCH v4 2/4] net/mlx5: fix Tx stats error counter definition Date: Thu, 14 Sep 2017 10:11:44 +0200 Message-ID: <20170914081144.GD11032@autoinstall.dev.6wind.com> References: <7b6d42c0c5e1a04f8483b6546ea0b1db8fb7ceee.1505133966.git.shahafs@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: yskoh@mellanox.com, adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org To: Shahaf Shuler Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 636C82C58 for ; Thu, 14 Sep 2017 10:11:55 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id a137so3947026wma.0 for ; Thu, 14 Sep 2017 01:11:55 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 13, 2017 at 01:50:37PM +0300, Shahaf Shuler wrote: > The current Tx error counter counts, according to its description, > the total number of packets not sent when TX ring full. It is reported > to application as part of oerrors field. > > The drop due to full ring is not the statistic that should be set on > oerrors field. Such number can be counted by the application using the > return value of the Tx burst function. > The number that should be set there is the number of packets the device > could not transmit in any way, even when it has resources. > > Therefore, replace this counter to count the total number of failed > transmitted packets. > > Fixes: 87011737b715 ("mlx5: add software counters") > Cc: stable@dpdk.org > Cc: adrien.mazarguil@6wind.com > > Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND