Re: [PATCH 09/14] fuzz/x86_emulate: Take multiple test files for inputs

From: Wei Liu <wei.liu2@citrix.com>
To: George Dunlap <george.dunlap@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Ian Jackson <ian.jackson@citrix.com>
Subject: Re: [PATCH 09/14] fuzz/x86_emulate: Take multiple test files for inputs
Date: Fri, 15 Sep 2017 14:42:53 +0100	[thread overview]
Message-ID: <20170915134253.ihqnqb2wjnqifpjy@citrix.com> (raw)
In-Reply-To: <c141beaa-0e41-0e22-532f-33d18ad9fca0@citrix.com>

On Fri, Sep 15, 2017 at 02:27:35PM +0100, George Dunlap wrote:
> >>                  perror("fopen");
> >> @@ -87,7 +94,9 @@ int main(int argc, char **argv)
> >>          if ( !feof(fp) || size > INPUT_SIZE )
> >>          {
> >>              printf("Input too large\n");
> >> -            exit(-1);
> >> +            if ( optind + 1 ==  argc )
> > 
> > What is this for?
> 
> Only call exit() when the file is too large if the current testcase is
> the last one.
> 
> One of the "interesting testcases" that AFL finds is always "The file
> was too large".  Without this clause, "afl-harness-cov [blah] queue/id*"
> would process testcases until it found that one, then stop processing,
> rather than processing the full set of them.
> 
> We could make this something like "if ( max == 1 )" (only exit if not in
> 'batch mode') if you think that would be better.
> 

Yes the new check looks clearer to me.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel