All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Chris Lew <clew@codeaurora.org>
Cc: andy.gross@linaro.org, david.brown@linaro.org,
	aneela@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] soc: qcom: smem: Support dynamic item limit
Date: Fri, 15 Sep 2017 11:40:11 -0700	[thread overview]
Message-ID: <20170915184011.GR2016@tuxbook> (raw)
In-Reply-To: <1505424302-29147-5-git-send-email-clew@codeaurora.org>

On Thu 14 Sep 14:25 PDT 2017, Chris Lew wrote:

> In V12 SMEM, SBL writes SMEM parameter information
> after the TOC. Use the SBL provided item count
> as the max item number.

Please wrap your commit messages at 72 chars (50 for the subject).

[..]
> +static u32 qcom_smem_get_dynamic_item(struct qcom_smem *smem)

This naming is too similar to the functions for looking up items, please
rename it to "qcom_smem_get_item_count()".

Regards,
Bjorn

  reply	other threads:[~2017-09-15 18:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-14 21:24 [PATCH v2 0/5] Qualcomm SMEM V12 Support Chris Lew
2017-09-14 21:24 ` [PATCH v2 1/5] soc: qcom: smem: Use le32_to_cpu for partition size comparison Chris Lew
2017-09-15  1:08   ` Bjorn Andersson
2017-09-15 18:33   ` Stephen Boyd
2017-09-15 18:39   ` Stephen Boyd
2017-09-15 20:53     ` Chris Lew
2017-10-05  3:59       ` Bjorn Andersson
2017-09-14 21:24 ` [PATCH v2 2/5] soc: qcom: smem: Read version by using the smem header Chris Lew
2017-09-15  1:09   ` Bjorn Andersson
2017-09-14 21:25 ` [PATCH v2 3/5] soc: qcom: smem: Support global partition Chris Lew
2017-09-15 18:33   ` Bjorn Andersson
2017-09-15 21:02     ` Chris Lew
2017-10-05  4:15       ` Bjorn Andersson
2017-09-14 21:25 ` [PATCH v2 4/5] soc: qcom: smem: Support dynamic item limit Chris Lew
2017-09-15 18:40   ` Bjorn Andersson [this message]
2017-09-14 21:25 ` [PATCH v2 5/5] soc: qcom: smem: Increase the number of hosts Chris Lew
2017-09-15 18:40   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170915184011.GR2016@tuxbook \
    --to=bjorn.andersson@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=aneela@codeaurora.org \
    --cc=clew@codeaurora.org \
    --cc=david.brown@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.