All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] [PATCH v5 5/6] iotests: Add test for non-string option reopening
Date: Sat, 16 Sep 2017 20:51:22 +0200	[thread overview]
Message-ID: <20170916185123.29255-6-mreitz@redhat.com> (raw)
In-Reply-To: <20170916185123.29255-1-mreitz@redhat.com>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/133     | 9 +++++++++
 tests/qemu-iotests/133.out | 5 +++++
 2 files changed, 14 insertions(+)

diff --git a/tests/qemu-iotests/133 b/tests/qemu-iotests/133
index 9d35a6a1ca..af6b3e1dd4 100755
--- a/tests/qemu-iotests/133
+++ b/tests/qemu-iotests/133
@@ -83,6 +83,15 @@ $QEMU_IO -c 'reopen -o driver=qcow2' $TEST_IMG
 $QEMU_IO -c 'reopen -o file.driver=file' $TEST_IMG
 $QEMU_IO -c 'reopen -o backing.driver=qcow2' $TEST_IMG
 
+echo
+echo "=== Check that reopening works with non-string options ==="
+echo
+
+# Using the json: pseudo-protocol we can create non-string options
+# (Invoke 'info' just so we get some output afterwards)
+IMGOPTSSYNTAX=false $QEMU_IO -f null-co -c 'reopen' -c 'info' \
+    "json:{'driver': 'null-co', 'size': 65536}"
+
 # success, all done
 echo "*** done"
 rm -f $seq.full
diff --git a/tests/qemu-iotests/133.out b/tests/qemu-iotests/133.out
index cc86b94880..f4a85aeb63 100644
--- a/tests/qemu-iotests/133.out
+++ b/tests/qemu-iotests/133.out
@@ -19,4 +19,9 @@ Cannot change the option 'driver'
 
 === Check that unchanged driver is okay ===
 
+
+=== Check that reopening works with non-string options ===
+
+format name: null-co
+format name: null-co
 *** done
-- 
2.13.5

  parent reply	other threads:[~2017-09-16 18:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-16 18:51 [Qemu-devel] [PATCH v5 0/6] block: Don't compare strings in bdrv_reopen_prepare() Max Reitz
2017-09-16 18:51 ` [Qemu-devel] [PATCH v5 1/6] qapi/qnull: Add own header Max Reitz
2017-09-18 14:05   ` Eric Blake
2017-09-21 11:45   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-10-02 13:13   ` [Qemu-devel] " Markus Armbruster
2017-09-16 18:51 ` [Qemu-devel] [PATCH v5 2/6] qapi/qlist: Add qlist_append_null() macro Max Reitz
2017-09-18 14:08   ` Eric Blake
2017-09-21 11:46   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-10-02 13:13   ` [Qemu-devel] " Markus Armbruster
2017-09-16 18:51 ` [Qemu-devel] [PATCH v5 3/6] qapi: Add qobject_is_equal() Max Reitz
2017-09-18 14:15   ` Eric Blake
2017-09-21 12:03   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-10-02 13:13   ` [Qemu-devel] " Markus Armbruster
2017-09-16 18:51 ` [Qemu-devel] [PATCH v5 4/6] block: qobject_is_equal() in bdrv_reopen_prepare() Max Reitz
2017-09-16 18:51 ` Max Reitz [this message]
2017-09-18 14:17   ` [Qemu-devel] [PATCH v5 5/6] iotests: Add test for non-string option reopening Eric Blake
2017-09-16 18:51 ` [Qemu-devel] [PATCH v5 6/6] tests: Add check-qobject for equality tests Max Reitz
2017-09-18 14:25   ` Eric Blake
2017-10-02 13:34   ` Markus Armbruster
2017-10-03 21:19     ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170916185123.29255-6-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.