All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: stefanha@redhat.com
Cc: netdev@vger.kernel.org, jhansen@vmware.com
Subject: Re: [PATCH] VSOCK: fix uapi/linux/vm_sockets.h incomplete types
Date: Tue, 19 Sep 2017 10:38:40 -0700 (PDT)	[thread overview]
Message-ID: <20170919.103840.379059301652331060.davem@davemloft.net> (raw)
In-Reply-To: <20170918152100.GF4141@stefanha-x1.localdomain>

From: Stefan Hajnoczi <stefanha@redhat.com>
Date: Mon, 18 Sep 2017 16:21:00 +0100

> On Fri, Sep 15, 2017 at 02:14:32PM -0700, David Miller wrote:
>> > diff --git a/include/uapi/linux/vm_sockets.h b/include/uapi/linux/vm_sockets.h
>> > index b4ed5d895699..4ae5c625ac56 100644
>> > --- a/include/uapi/linux/vm_sockets.h
>> > +++ b/include/uapi/linux/vm_sockets.h
>> > @@ -18,6 +18,10 @@
>> >  
>> >  #include <linux/socket.h>
>> >  
>> > +#ifndef __KERNEL__
>> > +#include <sys/socket.h> /* struct sockaddr */
>> > +#endif
>> > +
>> 
>> There is no precedence whatsoever to include sys/socket.h in _any_ UAPI
>> header file provided by the kernel.
> 
> <linux/if.h> does it for the same reason:
> 
> include/uapi/linux/if.h:#include <sys/socket.h>                 /* for struct sockaddr.         */

You don't need it for struct sockaddr, you need it for sa_family_t,
the comment is very misleading.

Please do as I have instructed and it will fix this problem.

Thank you.

  reply	other threads:[~2017-09-19 17:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-12 16:34 [PATCH] VSOCK: fix uapi/linux/vm_sockets.h incomplete types Stefan Hajnoczi
2017-09-13  7:55 ` Jorgen S. Hansen
2017-09-15 21:14 ` David Miller
2017-09-18 15:21   ` Stefan Hajnoczi
2017-09-19 17:38     ` David Miller [this message]
2017-09-20 15:22       ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170919.103840.379059301652331060.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jhansen@vmware.com \
    --cc=netdev@vger.kernel.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.