From: Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H . Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org
Subject: [PATCH v3 0/6] locking/rwsem/x86: Add stack frame dependency for some inline asm
Date: Tue, 19 Sep 2017 18:37:39 -0500 [thread overview]
Message-ID: <20170919233745.15343-1-miguel.bernal.marin@linux.intel.com> (raw)
In-Reply-To: <20170906052613.30058-1-miguel.bernal.marin@linux.intel.com>
Some warning were showed by objtool using gcc 7.2.0
kernel/locking/rwsem.o: warning: objtool: up_read()+0x11: call without frame pointer save/setup
kernel/locking/rwsem.o: warning: objtool: up_write()+0x17: call without frame pointer save/setup
kernel/locking/rwsem.o: warning: objtool: downgrade_write()+0x22: call without frame pointer save/setup
which means gcc placed an inline asm function and its call instruction before
the frame pointer setup.
This series forces a stack frame to be created before the call instruction
by listing the stack pointer as an output operand in the inline asm statement.
Also to be easy to maintain and understand the operands from the extended
assembler instructions were converted to named operands.
Changes in v3:
- Convert to named operands
Changes in v2:
- Update first parameter from _ASM_ADD to '%3' at __downgrade_write()
Miguel Bernal Marin (6):
locking/rwsem/x86: Add stack frame dependency for __up_read()
locking/rwsem/x86: Add stack frame dependency for __up_write()
locking/rwsem/x86: Add stack frame dependency for __downgrade_write()
x86, asm/rwsem: Use named operands in __up_read()
x86, asm/rwsem: Use named operands in __up_write()
x86, asm/rwsem: Use named operands in __downgrade_write()
arch/x86/include/asm/rwsem.h | 24 +++++++++++++++---------
1 file changed, 15 insertions(+), 9 deletions(-)
--
2.14.1
next prev parent reply other threads:[~2017-09-19 23:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 5:26 [PATCH 0/3] locking/rwsem/x86: Add stack frame dependency for some inline asm Miguel Bernal Marin
2017-09-06 5:26 ` [PATCH 1/3] locking/rwsem/x86: Add stack frame dependency for __up_read() Miguel Bernal Marin
2017-09-06 5:26 ` [PATCH 2/3] locking/rwsem/x86: Add stack frame dependency for __up_write() Miguel Bernal Marin
2017-09-06 5:26 ` [PATCH 3/3] locking/rwsem/x86: Add stack frame dependency for __downgrade_write() Miguel Bernal Marin
2017-09-06 21:33 ` Josh Poimboeuf
2017-09-06 22:14 ` Miguel Bernal Marin
2017-09-07 7:04 ` Peter Zijlstra
2017-09-06 22:44 ` [PATCH v2 0/3] locking/rwsem/x86: Add stack frame dependency for some inline asm Miguel Bernal Marin
2017-09-06 22:44 ` [PATCH v2 1/3] locking/rwsem/x86: Add stack frame dependency for __up_read() Miguel Bernal Marin
2017-09-07 7:12 ` Ingo Molnar
2017-09-14 21:42 ` Miguel Bernal Marin
2017-09-06 22:45 ` [PATCH v2 2/3] locking/rwsem/x86: Add stack frame dependency for __up_write() Miguel Bernal Marin
2017-09-06 22:45 ` [PATCH v2 3/3] locking/rwsem/x86: Add stack frame dependency for __downgrade_write() Miguel Bernal Marin
2017-09-06 23:05 ` [PATCH v2 0/3] locking/rwsem/x86: Add stack frame dependency for some inline asm Josh Poimboeuf
2017-09-19 23:37 ` Miguel Bernal Marin [this message]
2017-09-19 23:37 ` [PATCH v3 1/6] locking/rwsem/x86: Add stack frame dependency for __up_read() Miguel Bernal Marin
2017-09-19 23:37 ` [PATCH v3 2/6] locking/rwsem/x86: Add stack frame dependency for __up_write() Miguel Bernal Marin
2017-09-19 23:37 ` [PATCH v3 3/6] locking/rwsem/x86: Add stack frame dependency for __downgrade_write() Miguel Bernal Marin
2017-09-19 23:37 ` [PATCH v3 4/6] x86, asm/rwsem: Use named operands in __up_read() Miguel Bernal Marin
2017-09-19 23:37 ` [PATCH v3 5/6] x86, asm/rwsem: Use named operands in __up_write() Miguel Bernal Marin
2017-09-19 23:37 ` [PATCH v3 6/6] x86, asm/rwsem: Use named operands in __downgrade_write() Miguel Bernal Marin
2017-09-20 21:24 ` [PATCH v3 0/6] locking/rwsem/x86: Add stack frame dependency for some inline asm Josh Poimboeuf
2017-09-21 16:59 ` Miguel Bernal Marin
2017-09-25 17:34 ` Miguel Bernal Marin
2017-09-25 19:00 ` Josh Poimboeuf
2017-09-25 19:03 ` Josh Poimboeuf
2017-09-25 21:34 ` Miguel Bernal Marin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919233745.15343-1-miguel.bernal.marin@linux.intel.com \
--to=miguel.bernal.marin@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.