From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751786AbdISXiO (ORCPT ); Tue, 19 Sep 2017 19:38:14 -0400 Received: from mga14.intel.com ([192.55.52.115]:26175 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751698AbdISXiA (ORCPT ); Tue, 19 Sep 2017 19:38:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,419,1500966000"; d="scan'208";a="153297048" From: Miguel Bernal Marin To: Josh Poimboeuf , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" Cc: linux-kernel@vger.kernel.org, x86@kernel.org Subject: [PATCH v3 5/6] x86, asm/rwsem: Use named operands in __up_write() Date: Tue, 19 Sep 2017 18:37:44 -0500 Message-Id: <20170919233745.15343-6-miguel.bernal.marin@linux.intel.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170919233745.15343-1-miguel.bernal.marin@linux.intel.com> References: <20170906052613.30058-1-miguel.bernal.marin@linux.intel.com> <20170919233745.15343-1-miguel.bernal.marin@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since GCC version 3.1, it is possible to specify input and output operands using symbolic names which can be referenced within the assembler code. Convert to named operands makes easy to understand and maintain for future changes. Signed-off-by: Miguel Bernal Marin --- arch/x86/include/asm/rwsem.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/rwsem.h b/arch/x86/include/asm/rwsem.h index 2b3fb6d316f5..3245902e961f 100644 --- a/arch/x86/include/asm/rwsem.h +++ b/arch/x86/include/asm/rwsem.h @@ -189,14 +189,14 @@ static inline void __up_write(struct rw_semaphore *sem) register void *__sp asm(_ASM_SP); asm volatile("# beginning __up_write\n\t" - LOCK_PREFIX " xadd %1,(%3)\n\t" + LOCK_PREFIX " xadd %[tmp],(%[sem])\n\t" /* subtracts 0xffff0001, returns the old value */ " jns 1f\n\t" " call call_rwsem_wake\n" /* expects old value in %edx */ "1:\n\t" "# ending __up_write\n" - : "+m" (sem->count), "=d" (tmp), "+r" (__sp) - : "a" (sem), "1" (-RWSEM_ACTIVE_WRITE_BIAS) + : "+m" (sem->count), [tmp] "=d" (tmp), "+r" (__sp) + : [sem] "a" (sem), "[tmp]" (-RWSEM_ACTIVE_WRITE_BIAS) : "memory", "cc"); } -- 2.14.1