From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751612AbdITArY (ORCPT ); Tue, 19 Sep 2017 20:47:24 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:38537 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751497AbdITArV (ORCPT ); Tue, 19 Sep 2017 20:47:21 -0400 X-Google-Smtp-Source: AOwi7QDt+hUr4IVP3JZd6Q8sQhNRQyq2obPq0tP3LJUd9kNN65VIMcCHgSnyUJEdBBLmhZYNXwHr/g== Date: Wed, 20 Sep 2017 09:47:15 +0900 From: Sergey Senozhatsky To: Helge Deller Cc: Sergey Senozhatsky , Sergey Senozhatsky , "Luck, Tony" , Fenghua Yu , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , "James E . J . Bottomley" , Petr Mladek , Steven Rostedt , Andrew Morton , Jessica Yu , Alexei Starovoitov , linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers Message-ID: <20170920004715.GA6298@jagdpanzerIV.localdomain> References: <20170916035347.19705-1-sergey.senozhatsky@gmail.com> <20170918174432.4fksyzco2g6gczwe@intel.com> <20170918183902.GA30752@p100.box> <20170919020537.GA16991@jagdpanzerIV.localdomain> <20170919200357.GA15803@p100.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170919200357.GA15803@p100.box> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (09/19/17 22:03), Helge Deller wrote: [..] > Your implementation of dereference_module_function_descriptor() in > arch/parisc/kernel/module.c is faulty. > mod->arch.fdesc_offset is relative to the base address of the module, > so you need to add to mod->core_layout.base. aha, got it. I should have figured that out. many thanks! > Here is the relevant patch to fix this issue (against mainline). > Additionally I compare against mod->arch.fdesc_count instead of > mod->arch.fdesc_max. hmm, .fdesc_max looked relevant to me. it's count_fdescs() - the number of R_PARISC_FPTR64 relocation entries. but ok, will use .fdesc_count. > Can you please fold it into your patch > [PATCH 4/5] parisc64: Add .opd based function descriptor dereference > for the next round? sure, will fold. + SoB. I think I'll try to re-spin the series today (or tomorrow, I'm slightly overloaded with another stuff right now). I've received enough bug reports no need to wait for another week ;) -ss From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Date: Wed, 20 Sep 2017 00:47:15 +0000 Subject: Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers Message-Id: <20170920004715.GA6298@jagdpanzerIV.localdomain> List-Id: References: <20170916035347.19705-1-sergey.senozhatsky@gmail.com> <20170918174432.4fksyzco2g6gczwe@intel.com> <20170918183902.GA30752@p100.box> <20170919020537.GA16991@jagdpanzerIV.localdomain> <20170919200357.GA15803@p100.box> In-Reply-To: <20170919200357.GA15803@p100.box> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Helge Deller Cc: Sergey Senozhatsky , Sergey Senozhatsky , "Luck, Tony" , Fenghua Yu , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , "James E . J . Bottomley" , Petr Mladek , Steven Rostedt , Andrew Morton , Jessica Yu , Alexei Starovoitov , linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org On (09/19/17 22:03), Helge Deller wrote: [..] > Your implementation of dereference_module_function_descriptor() in > arch/parisc/kernel/module.c is faulty. > mod->arch.fdesc_offset is relative to the base address of the module, > so you need to add to mod->core_layout.base. aha, got it. I should have figured that out. many thanks! > Here is the relevant patch to fix this issue (against mainline). > Additionally I compare against mod->arch.fdesc_count instead of > mod->arch.fdesc_max. hmm, .fdesc_max looked relevant to me. it's count_fdescs() - the number of R_PARISC_FPTR64 relocation entries. but ok, will use .fdesc_count. > Can you please fold it into your patch > [PATCH 4/5] parisc64: Add .opd based function descriptor dereference > for the next round? sure, will fold. + SoB. I think I'll try to re-spin the series today (or tomorrow, I'm slightly overloaded with another stuff right now). I've received enough bug reports no need to wait for another week ;) -ss