From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751771AbdITHw1 (ORCPT ); Wed, 20 Sep 2017 03:52:27 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:46761 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510AbdITHwY (ORCPT ); Wed, 20 Sep 2017 03:52:24 -0400 Date: Wed, 20 Sep 2017 09:52:23 +0200 From: Maxime Ripard To: icenowy@aosc.io Cc: Lee Jones , Rob Herring , Chen-Yu Tsai , Jonathan Cameron , Quentin Schulz , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [linux-sunxi] Re: [PATCH v4 1/6] dt-bindings: update the Allwinner GPADC device tree binding for H3 Message-ID: <20170920075223.jaeswlhcqgu4yhse@flea.home> References: <20170914145251.21784-1-icenowy@aosc.io> <20170914145251.21784-2-icenowy@aosc.io> <20170918073336.j7finend3g76chsu@flea.lan> <310CE549-B8CE-4C0C-95B1-B545E38BDAF5@aosc.io> <20170918083045.7bfiialtbm7w6i7j@flea.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="j6c5m4fcyye26ziz" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170914 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --j6c5m4fcyye26ziz Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 18, 2017 at 03:47:25PM +0000, icenowy@aosc.io wrote: > =E5=9C=A8 2017-09-18 16:30=EF=BC=8CMaxime Ripard =E5=86=99=E9=81=93=EF=BC= =9A > > On Mon, Sep 18, 2017 at 03:36:43PM +0800, Icenowy Zheng wrote: > > > =E4=BA=8E 2017=E5=B9=B49=E6=9C=8818=E6=97=A5 GMT+08:00 =E4=B8=8B=E5= =8D=883:33:36, Maxime Ripard > > > =E5=86=99=E5=88=B0: > > > >On Thu, Sep 14, 2017 at 10:52:46PM +0800, Icenowy Zheng wrote: > > > >> Allwinner H3 features a thermal sensor like the one in A33, but has > > > >its > > > >> register re-arranged, the clock divider moved to CCU (originally t= he > > > >> clock divider is in ADC) and added a pair of bus clock and reset. > > > >> > > > >> Update the binding document to cover H3. > > > >> > > > >> Signed-off-by: Icenowy Zheng > > > >> Reviewed-by: Chen-Yu Tsai > > > >> --- > > > >> Changes in v4: > > > >> - Add nvmem calibration data (not yet used by the driver) > > > >> Changes in v3: > > > >> - Clock name changes. > > > >> - Example node name changes. > > > >> - Add interupts (not yet used by the driver). > > > >> > > > >> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 30 > > > >++++++++++++++++++++-- > > > >> 1 file changed, 28 insertions(+), 2 deletions(-) > > > >> > > > >> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > > > >b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > > > >> index badff3611a98..6c470d584bf9 100644 > > > >> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > > > >> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > > > >> @@ -4,12 +4,26 @@ The Allwinner SoCs all have an ADC that can also > > > >act as a thermal sensor > > > >> and sometimes as a touchscreen controller. > > > >> > > > >> Required properties: > > > >> - - compatible: "allwinner,sun8i-a33-ths", > > > >> + - compatible: must contain one of the following compatibles: > > > >> + - "allwinner,sun8i-a33-ths" > > > >> + - "allwinner,sun8i-h3-ths" > > > >> - reg: mmio address range of the chip, > > > >> - #thermal-sensor-cells: shall be 0, > > > >> - #io-channel-cells: shall be 0, > > > >> > > > >> -Example: > > > >> +Optional properties: > > > >> + - nvmem-cells: A phandle to the calibration data provided by a > > > >nvmem device. > > > >> + If unspecified default values shall be used. > > > >> + - nvmem-cell-names: Should be "calibration-data" > > > > > > > >I'd prefer to have which sensor it applies to here. It wouldn't chan= ge > > > >anything for the H3, but it definitely does for example for the A83t > > > >that has two sensors, one for each cluster, and one for the GPU, each > > > >with calibration data. > > > > > > > >What about cluster0-calibration? >=20 > I prefer sensor0-calibration to sensor3-calibration now. > (Theortically the new generation THS can support up to 4 sensors) The mapping that explains what sensor0 means can change in the future. It's better to be explicit here, and just say upfront what it's about. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --j6c5m4fcyye26ziz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZwh43AAoJEBx+YmzsjxAg6coQAJhmcNGdIUCdL6g5L/2GIVnR VU2BrHYsmzIhV6p6K0Bh41Nj6vzoL3s8EbJgOKT1zCkmi439nAsEhwJZJicfodz1 6axkC+mzw5pVapG+ooihuFdIFKj8X139EQta5t9kuyOy3OUhHrwqDNqq4Y6UEVrl 0lLYMq9O01mLhXtN8WDwAnqP5Q/lR+CHX4tF+IpNIq2yj1muSXbu0h5+ZLtoS96b bH0679EuiULHCQ8JYjz+CxoK/wvoSfOmHqnEzcE6ZmtED5CchegUilHpzhxlrmLI zinIQExlQHP3O1pa6sEQ51cplXyJes87QcTo2lY6LgWsKPCTx1CoBaIkGvs8Mv43 53WwQhJOBv6OaZx3grCzUxu0DlmnEjr4RKaVrgI1OR7r/ZGkGt9/j8qCn9J/N2Kn gGd8TSt6nobVYWMc+1txdUf4XhsSvpckFm/WsLrZkX+sSdBDY3PBnx6HwtTt0IPN YmkEUs6Jx7rKZwBLAMtBSJ5MBFZjuqgVgdi+EILlCFxe+lg9wkUSGRlIxUYPRN5E iQFQUy12peGDVZjusGGmHrEJL5ygKCGEVvK00YiujkGXWNiRYKncz/BfeRwBXLns opuuCs7wXfwI5buNmakpYc+VRlWwa4bEn09/GY4+gDiZsMgA8E2fuVIZVXJMXjTr asat+94Ttiohg2ryCW6D =bUAz -----END PGP SIGNATURE----- --j6c5m4fcyye26ziz-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: Re: [PATCH v4 1/6] dt-bindings: update the Allwinner GPADC device tree binding for H3 Date: Wed, 20 Sep 2017 09:52:23 +0200 Message-ID: <20170920075223.jaeswlhcqgu4yhse@flea.home> References: <20170914145251.21784-1-icenowy@aosc.io> <20170914145251.21784-2-icenowy@aosc.io> <20170918073336.j7finend3g76chsu@flea.lan> <310CE549-B8CE-4C0C-95B1-B545E38BDAF5@aosc.io> <20170918083045.7bfiialtbm7w6i7j@flea.lan> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="j6c5m4fcyye26ziz" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: icenowy-h8G6r0blFSE@public.gmane.org Cc: Lee Jones , Rob Herring , Chen-Yu Tsai , Jonathan Cameron , Quentin Schulz , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --j6c5m4fcyye26ziz Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 18, 2017 at 03:47:25PM +0000, icenowy-h8G6r0blFSE@public.gmane.org wrote: > =E5=9C=A8 2017-09-18 16:30=EF=BC=8CMaxime Ripard =E5=86=99=E9=81=93=EF=BC= =9A > > On Mon, Sep 18, 2017 at 03:36:43PM +0800, Icenowy Zheng wrote: > > > =E4=BA=8E 2017=E5=B9=B49=E6=9C=8818=E6=97=A5 GMT+08:00 =E4=B8=8B=E5= =8D=883:33:36, Maxime Ripard > > > =E5=86=99=E5=88=B0: > > > >On Thu, Sep 14, 2017 at 10:52:46PM +0800, Icenowy Zheng wrote: > > > >> Allwinner H3 features a thermal sensor like the one in A33, but ha= s > > > >its > > > >> register re-arranged, the clock divider moved to CCU (originally t= he > > > >> clock divider is in ADC) and added a pair of bus clock and reset. > > > >> > > > >> Update the binding document to cover H3. > > > >> > > > >> Signed-off-by: Icenowy Zheng > > > >> Reviewed-by: Chen-Yu Tsai > > > >> --- > > > >> Changes in v4: > > > >> - Add nvmem calibration data (not yet used by the driver) > > > >> Changes in v3: > > > >> - Clock name changes. > > > >> - Example node name changes. > > > >> - Add interupts (not yet used by the driver). > > > >> > > > >> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 30 > > > >++++++++++++++++++++-- > > > >> 1 file changed, 28 insertions(+), 2 deletions(-) > > > >> > > > >> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > > > >b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > > > >> index badff3611a98..6c470d584bf9 100644 > > > >> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > > > >> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > > > >> @@ -4,12 +4,26 @@ The Allwinner SoCs all have an ADC that can also > > > >act as a thermal sensor > > > >> and sometimes as a touchscreen controller. > > > >> > > > >> Required properties: > > > >> - - compatible: "allwinner,sun8i-a33-ths", > > > >> + - compatible: must contain one of the following compatibles: > > > >> + - "allwinner,sun8i-a33-ths" > > > >> + - "allwinner,sun8i-h3-ths" > > > >> - reg: mmio address range of the chip, > > > >> - #thermal-sensor-cells: shall be 0, > > > >> - #io-channel-cells: shall be 0, > > > >> > > > >> -Example: > > > >> +Optional properties: > > > >> + - nvmem-cells: A phandle to the calibration data provided by a > > > >nvmem device. > > > >> + If unspecified default values shall be used. > > > >> + - nvmem-cell-names: Should be "calibration-data" > > > > > > > >I'd prefer to have which sensor it applies to here. It wouldn't chan= ge > > > >anything for the H3, but it definitely does for example for the A83t > > > >that has two sensors, one for each cluster, and one for the GPU, eac= h > > > >with calibration data. > > > > > > > >What about cluster0-calibration? >=20 > I prefer sensor0-calibration to sensor3-calibration now. > (Theortically the new generation THS can support up to 4 sensors) The mapping that explains what sensor0 means can change in the future. It's better to be explicit here, and just say upfront what it's about. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. --j6c5m4fcyye26ziz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZwh43AAoJEBx+YmzsjxAg6coQAJhmcNGdIUCdL6g5L/2GIVnR VU2BrHYsmzIhV6p6K0Bh41Nj6vzoL3s8EbJgOKT1zCkmi439nAsEhwJZJicfodz1 6axkC+mzw5pVapG+ooihuFdIFKj8X139EQta5t9kuyOy3OUhHrwqDNqq4Y6UEVrl 0lLYMq9O01mLhXtN8WDwAnqP5Q/lR+CHX4tF+IpNIq2yj1muSXbu0h5+ZLtoS96b bH0679EuiULHCQ8JYjz+CxoK/wvoSfOmHqnEzcE6ZmtED5CchegUilHpzhxlrmLI zinIQExlQHP3O1pa6sEQ51cplXyJes87QcTo2lY6LgWsKPCTx1CoBaIkGvs8Mv43 53WwQhJOBv6OaZx3grCzUxu0DlmnEjr4RKaVrgI1OR7r/ZGkGt9/j8qCn9J/N2Kn gGd8TSt6nobVYWMc+1txdUf4XhsSvpckFm/WsLrZkX+sSdBDY3PBnx6HwtTt0IPN YmkEUs6Jx7rKZwBLAMtBSJ5MBFZjuqgVgdi+EILlCFxe+lg9wkUSGRlIxUYPRN5E iQFQUy12peGDVZjusGGmHrEJL5ygKCGEVvK00YiujkGXWNiRYKncz/BfeRwBXLns opuuCs7wXfwI5buNmakpYc+VRlWwa4bEn09/GY4+gDiZsMgA8E2fuVIZVXJMXjTr asat+94Ttiohg2ryCW6D =bUAz -----END PGP SIGNATURE----- --j6c5m4fcyye26ziz-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Wed, 20 Sep 2017 09:52:23 +0200 Subject: [linux-sunxi] Re: [PATCH v4 1/6] dt-bindings: update the Allwinner GPADC device tree binding for H3 In-Reply-To: References: <20170914145251.21784-1-icenowy@aosc.io> <20170914145251.21784-2-icenowy@aosc.io> <20170918073336.j7finend3g76chsu@flea.lan> <310CE549-B8CE-4C0C-95B1-B545E38BDAF5@aosc.io> <20170918083045.7bfiialtbm7w6i7j@flea.lan> Message-ID: <20170920075223.jaeswlhcqgu4yhse@flea.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Sep 18, 2017 at 03:47:25PM +0000, icenowy at aosc.io wrote: > ? 2017-09-18 16:30?Maxime Ripard ??? > > On Mon, Sep 18, 2017 at 03:36:43PM +0800, Icenowy Zheng wrote: > > > ? 2017?9?18? GMT+08:00 ??3:33:36, Maxime Ripard > > > ??: > > > >On Thu, Sep 14, 2017 at 10:52:46PM +0800, Icenowy Zheng wrote: > > > >> Allwinner H3 features a thermal sensor like the one in A33, but has > > > >its > > > >> register re-arranged, the clock divider moved to CCU (originally the > > > >> clock divider is in ADC) and added a pair of bus clock and reset. > > > >> > > > >> Update the binding document to cover H3. > > > >> > > > >> Signed-off-by: Icenowy Zheng > > > >> Reviewed-by: Chen-Yu Tsai > > > >> --- > > > >> Changes in v4: > > > >> - Add nvmem calibration data (not yet used by the driver) > > > >> Changes in v3: > > > >> - Clock name changes. > > > >> - Example node name changes. > > > >> - Add interupts (not yet used by the driver). > > > >> > > > >> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 30 > > > >++++++++++++++++++++-- > > > >> 1 file changed, 28 insertions(+), 2 deletions(-) > > > >> > > > >> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > > > >b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > > > >> index badff3611a98..6c470d584bf9 100644 > > > >> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > > > >> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > > > >> @@ -4,12 +4,26 @@ The Allwinner SoCs all have an ADC that can also > > > >act as a thermal sensor > > > >> and sometimes as a touchscreen controller. > > > >> > > > >> Required properties: > > > >> - - compatible: "allwinner,sun8i-a33-ths", > > > >> + - compatible: must contain one of the following compatibles: > > > >> + - "allwinner,sun8i-a33-ths" > > > >> + - "allwinner,sun8i-h3-ths" > > > >> - reg: mmio address range of the chip, > > > >> - #thermal-sensor-cells: shall be 0, > > > >> - #io-channel-cells: shall be 0, > > > >> > > > >> -Example: > > > >> +Optional properties: > > > >> + - nvmem-cells: A phandle to the calibration data provided by a > > > >nvmem device. > > > >> + If unspecified default values shall be used. > > > >> + - nvmem-cell-names: Should be "calibration-data" > > > > > > > >I'd prefer to have which sensor it applies to here. It wouldn't change > > > >anything for the H3, but it definitely does for example for the A83t > > > >that has two sensors, one for each cluster, and one for the GPU, each > > > >with calibration data. > > > > > > > >What about cluster0-calibration? > > I prefer sensor0-calibration to sensor3-calibration now. > (Theortically the new generation THS can support up to 4 sensors) The mapping that explains what sensor0 means can change in the future. It's better to be explicit here, and just say upfront what it's about. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: