From: Icenowy Zheng <icenowy@aosc.io>
To: Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Jonathan Cameron <jic23@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Quentin Schulz <quentin.schulz@free-electrons.com>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
linux-sunxi@googlegroups.com, Icenowy Zheng <icenowy@aosc.io>
Subject: [RFC PATCH 2/7] iio: adc: axp20x-adc: allow to skip ADC rate setup now
Date: Wed, 20 Sep 2017 23:18:09 +0800 [thread overview]
Message-ID: <20170920151814.22461-3-icenowy@aosc.io> (raw)
In-Reply-To: <20170920151814.22461-1-icenowy@aosc.io>
The ADC rate setup on AXP803 is more complex than AXP20x/22x.
As it's not a necessary setup, allow it to be skipped, to allow simpler
AXP803 support now.
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
drivers/iio/adc/axp20x_adc.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/axp20x_adc.c b/drivers/iio/adc/axp20x_adc.c
index 11e177180ea0..93dd6b80059e 100644
--- a/drivers/iio/adc/axp20x_adc.c
+++ b/drivers/iio/adc/axp20x_adc.c
@@ -556,8 +556,10 @@ static int axp20x_probe(struct platform_device *pdev)
AXP20X_ADC_EN2_MASK, AXP20X_ADC_EN2_MASK);
/* Configure ADCs rate */
- regmap_update_bits(info->regmap, AXP20X_ADC_RATE, AXP20X_ADC_RATE_MASK,
- info->data->adc_rate(100));
+ if (info->data->adc_rate)
+ regmap_update_bits(info->regmap, AXP20X_ADC_RATE,
+ AXP20X_ADC_RATE_MASK,
+ info->data->adc_rate(100));
ret = iio_map_array_register(indio_dev, info->data->maps);
if (ret < 0) {
--
2.13.5
WARNING: multiple messages have this Message-ID
From: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Quentin Schulz
<quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
Subject: [RFC PATCH 2/7] iio: adc: axp20x-adc: allow to skip ADC rate setup now
Date: Wed, 20 Sep 2017 23:18:09 +0800 [thread overview]
Message-ID: <20170920151814.22461-3-icenowy@aosc.io> (raw)
In-Reply-To: <20170920151814.22461-1-icenowy-h8G6r0blFSE@public.gmane.org>
The ADC rate setup on AXP803 is more complex than AXP20x/22x.
As it's not a necessary setup, allow it to be skipped, to allow simpler
AXP803 support now.
Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
---
drivers/iio/adc/axp20x_adc.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/axp20x_adc.c b/drivers/iio/adc/axp20x_adc.c
index 11e177180ea0..93dd6b80059e 100644
--- a/drivers/iio/adc/axp20x_adc.c
+++ b/drivers/iio/adc/axp20x_adc.c
@@ -556,8 +556,10 @@ static int axp20x_probe(struct platform_device *pdev)
AXP20X_ADC_EN2_MASK, AXP20X_ADC_EN2_MASK);
/* Configure ADCs rate */
- regmap_update_bits(info->regmap, AXP20X_ADC_RATE, AXP20X_ADC_RATE_MASK,
- info->data->adc_rate(100));
+ if (info->data->adc_rate)
+ regmap_update_bits(info->regmap, AXP20X_ADC_RATE,
+ AXP20X_ADC_RATE_MASK,
+ info->data->adc_rate(100));
ret = iio_map_array_register(indio_dev, info->data->maps);
if (ret < 0) {
--
2.13.5
WARNING: multiple messages have this Message-ID
From: icenowy@aosc.io (Icenowy Zheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/7] iio: adc: axp20x-adc: allow to skip ADC rate setup now
Date: Wed, 20 Sep 2017 23:18:09 +0800 [thread overview]
Message-ID: <20170920151814.22461-3-icenowy@aosc.io> (raw)
In-Reply-To: <20170920151814.22461-1-icenowy@aosc.io>
The ADC rate setup on AXP803 is more complex than AXP20x/22x.
As it's not a necessary setup, allow it to be skipped, to allow simpler
AXP803 support now.
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
drivers/iio/adc/axp20x_adc.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/axp20x_adc.c b/drivers/iio/adc/axp20x_adc.c
index 11e177180ea0..93dd6b80059e 100644
--- a/drivers/iio/adc/axp20x_adc.c
+++ b/drivers/iio/adc/axp20x_adc.c
@@ -556,8 +556,10 @@ static int axp20x_probe(struct platform_device *pdev)
AXP20X_ADC_EN2_MASK, AXP20X_ADC_EN2_MASK);
/* Configure ADCs rate */
- regmap_update_bits(info->regmap, AXP20X_ADC_RATE, AXP20X_ADC_RATE_MASK,
- info->data->adc_rate(100));
+ if (info->data->adc_rate)
+ regmap_update_bits(info->regmap, AXP20X_ADC_RATE,
+ AXP20X_ADC_RATE_MASK,
+ info->data->adc_rate(100));
ret = iio_map_array_register(indio_dev, info->data->maps);
if (ret < 0) {
--
2.13.5
next prev parent reply other threads:[~2017-09-20 15:18 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 15:18 [RFC PATCH 0/7] AXP803 AC/Battery support Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` [RFC PATCH 1/7] dt-bindings: add compatibles for AXP803 Battery/USB power supplies Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-25 9:14 ` Quentin Schulz
2017-09-25 9:14 ` Quentin Schulz
2017-09-25 9:14 ` Quentin Schulz
2017-09-20 15:18 ` Icenowy Zheng [this message]
2017-09-20 15:18 ` [RFC PATCH 2/7] iio: adc: axp20x-adc: allow to skip ADC rate setup now Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-25 7:20 ` Quentin Schulz
2017-09-25 7:20 ` Quentin Schulz
2017-09-20 15:18 ` [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803 Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-24 14:32 ` Jonathan Cameron
2017-09-24 14:32 ` Jonathan Cameron
2017-09-24 14:32 ` Jonathan Cameron
2017-09-25 8:48 ` Quentin Schulz
2017-09-25 8:48 ` Quentin Schulz
2017-09-25 8:48 ` Quentin Schulz
2017-09-20 15:18 ` [RFC PATCH 4/7] power: supply: axp20x-battery: support AXP803 Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-24 14:34 ` Jonathan Cameron
2017-09-24 14:34 ` Jonathan Cameron
2017-09-24 14:34 ` Jonathan Cameron
2017-09-25 8:58 ` Quentin Schulz
2017-09-25 8:58 ` Quentin Schulz
2017-09-25 8:58 ` Quentin Schulz
2017-09-20 15:18 ` [RFC PATCH 5/7] mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-25 9:11 ` Quentin Schulz
2017-09-25 9:11 ` Quentin Schulz
2017-09-25 9:11 ` Quentin Schulz
2017-09-25 9:14 ` Icenowy Zheng
2017-09-25 9:14 ` Icenowy Zheng
2017-09-25 9:14 ` Icenowy Zheng
2017-09-25 9:19 ` [linux-sunxi] " Chen-Yu Tsai
2017-09-25 9:19 ` Chen-Yu Tsai
2017-09-25 9:19 ` Chen-Yu Tsai
2017-09-25 9:19 ` Chen-Yu Tsai
2017-09-25 9:24 ` Quentin Schulz
2017-09-25 9:24 ` Quentin Schulz
2017-09-25 9:24 ` Quentin Schulz
2017-09-20 15:18 ` [RFC PATCH 7/7] arm64: allwinner: a64: enable AC and Battery for Pine64 Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-21 14:46 ` [RFC PATCH 0/7] AXP803 AC/Battery support Jonathan Cameron
2017-09-21 14:46 ` Jonathan Cameron
2017-09-21 14:46 ` Jonathan Cameron
2017-09-21 15:20 ` Icenowy Zheng
2017-09-21 15:20 ` Icenowy Zheng
2017-09-21 15:20 ` Icenowy Zheng
2017-09-24 14:36 ` Jonathan Cameron
2017-09-24 14:36 ` Jonathan Cameron
2017-09-25 9:22 ` Quentin Schulz
2017-09-25 9:22 ` Quentin Schulz
2017-09-25 9:22 ` Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920151814.22461-3-icenowy@aosc.io \
--to=icenowy@aosc.io \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=quentin.schulz@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.