All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Stezenbach <js@sig21.net>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
	Carlo Caione <carlo@endlessm.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Darren Hart <dvhart@infradead.org>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Takashi Iwai <tiwai@suse.de>,
	linux-acpi@vger.kernel.org
Subject: Re: S0ix failure due to "clk: x86: Do not gate clocks enabled by the firmware"
Date: Thu, 21 Sep 2017 18:23:07 +0200	[thread overview]
Message-ID: <20170921162307.amdz2uyei7eackhs@sig21.net> (raw)
In-Reply-To: <4036229.gTT6xKEFIS@aspire.rjw.lan>

On Thu, Sep 21, 2017 at 04:21:46PM +0200, Rafael J. Wysocki wrote:
> So I would be inclined to think of that as a BIOS issue.

OK, wrt $Subject it sparks the question how to fix the
issue exposed by commit d31fd43c0f9a4 "clk: x86: Do not
gate clocks enabled by the firmware".  Add quirks to
the drivers for the devices that have the dangling
PowerResources and manually call _OFF/_ON during suspend/resume?

I must admit I haven't looked deeper into the issue yet,
i.e. I don't know which clock causes S0ix failure.
If I understand correctly, before d31fd43c0f9a4 the
clk framework would just disable all unused clocks
registered by clk-pmc-atom.c, which are all of then except
CLK3 which is used by the audio codec. And the audio codec
would disable CLK3 during suspend.
After d31fd43c0f9a4 all clocks that BIOS had enabled during boot
are kept running.  Presumably we could also add the quirk to
clk-pmc-atom.c to bypass what d31fd43c0f9a4 added on Asus E200HA?


Thanks,
Johannes

  reply	other threads:[~2017-09-21 16:23 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-06 20:42 S0ix failure due to "clk: x86: Do not gate clocks enabled by the firmware" Johannes Stezenbach
2017-09-06 21:02 ` Pierre-Louis Bossart
2017-09-08 13:49   ` Johannes Stezenbach
2017-09-21  9:40     ` Johannes Stezenbach
2017-09-21 14:21       ` Rafael J. Wysocki
2017-09-21 16:23         ` Johannes Stezenbach [this message]
2017-09-21 22:20           ` Rafael J. Wysocki
2017-09-21 22:24             ` Rafael J. Wysocki
2017-09-21 22:35           ` Rafael J. Wysocki
2017-09-22  8:04             ` Johannes Stezenbach
2017-09-22 12:27               ` Takashi Iwai
2017-09-22 21:04                 ` Johannes Stezenbach
2017-09-22 22:12                 ` Rafael J. Wysocki
2017-09-22 22:12                   ` Rafael J. Wysocki
2017-09-22 22:09               ` Rafael J. Wysocki
2017-09-25 19:17                 ` Johannes Stezenbach
2017-09-25 19:21                   ` [RFC PATCH 1/2] platform/x86: add Atom PMC quirk to disable SATA Johannes Stezenbach
2017-12-13  0:00                     ` Rafael J. Wysocki
2017-12-13  0:00                       ` Rafael J. Wysocki
2017-12-13  8:53                       ` Hans de Goede
2017-12-13 11:13                         ` Johannes Stezenbach
2017-12-13 15:25                         ` Michael Turquette
2017-12-13 16:04                           ` Hans de Goede
2017-12-13 16:22                             ` Johannes Stezenbach
2017-12-13 16:37                               ` Hans de Goede
2017-12-13 19:33                                 ` Andy Shevchenko
2017-12-13 19:33                                   ` Andy Shevchenko
2017-12-14 10:53                                   ` Hans de Goede
2017-09-25 19:23                 ` [RFC PATCH 2/2] clk: x86: Disable unused clocks to fix S0ix Johannes Stezenbach
2017-12-13  0:01                   ` Rafael J. Wysocki
2017-12-13  0:01                     ` Rafael J. Wysocki
2017-12-13  8:56                     ` Hans de Goede
2017-12-13 10:20                       ` Carlo Caione
2017-12-13 11:22                       ` Johannes Stezenbach
2017-12-13 14:25                         ` Pierre-Louis Bossart
2017-12-13 14:29                       ` Andy Shevchenko
2017-09-06 21:14 ` S0ix failure due to "clk: x86: Do not gate clocks enabled by the firmware" Carlo Caione
2017-09-18  8:00   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170921162307.amdz2uyei7eackhs@sig21.net \
    --to=js@sig21.net \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=carlo@endlessm.com \
    --cc=dvhart@infradead.org \
    --cc=enric.balletbo@collabora.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.