All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com
Cc: linux-media@vger.kernel.org, devicetree@kernel.org
Subject: [PATCH v3 4/4] as3645a: Unregister indicator LED on device unbind
Date: Fri, 22 Sep 2017 12:32:38 +0300	[thread overview]
Message-ID: <20170922093238.13070-5-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20170922093238.13070-1-sakari.ailus@linux.intel.com>

The indicator LED was registered in probe but was not removed in driver
remove callback. Fix this.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/leds/leds-as3645a.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
index 605e0c64e974..9a257f969300 100644
--- a/drivers/leds/leds-as3645a.c
+++ b/drivers/leds/leds-as3645a.c
@@ -743,6 +743,7 @@ static int as3645a_remove(struct i2c_client *client)
 	as3645a_set_control(flash, AS_MODE_EXT_TORCH, false);
 
 	v4l2_flash_release(flash->vf);
+	v4l2_flash_release(flash->vfind);
 
 	led_classdev_flash_unregister(&flash->fled);
 	led_classdev_unregister(&flash->iled_cdev);
-- 
2.11.0

  parent reply	other threads:[~2017-09-22  9:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-22  9:32 [PATCH v3 0/4] AS3645A fixes Sakari Ailus
2017-09-22  9:32 ` [PATCH v3 1/4] as3645a: Use ams,input-max-microamp as documented in DT bindings Sakari Ailus
2017-09-22  9:32 ` [PATCH v3 2/4] dt: bindings: as3645a: Use LED number to refer to LEDs Sakari Ailus
2017-09-22  9:32 ` [PATCH v3 3/4] as3645a: Use integer numbers for parsing LEDs Sakari Ailus
2017-09-22  9:32 ` Sakari Ailus [this message]
2017-09-22 19:37 ` [PATCH v3 0/4] AS3645A fixes Jacek Anaszewski
     [not found]   ` <650b7cb3-f7dd-5959-3147-df7284415521-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-22 21:25     ` Sakari Ailus
2017-09-22 21:25       ` Sakari Ailus
2017-09-23 19:39       ` Jacek Anaszewski
     [not found]         ` <a15c166f-48ec-faf8-a500-940fd912813a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-24 13:56           ` Sakari Ailus
2017-09-24 13:56             ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170922093238.13070-5-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=devicetree@kernel.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.