From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH v3 4/8] ethdev: add GTP items to support flow API Date: Fri, 22 Sep 2017 15:39:19 +0200 Message-ID: <20170922133919.GD11375@6wind.com> References: <1504783263-20575-1-git-send-email-beilei.xing@intel.com> <1506119714-53437-1-git-send-email-beilei.xing@intel.com> <1506119714-53437-5-git-send-email-beilei.xing@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: jingjing.wu@intel.com, andrey.chilikin@intel.com, dev@dpdk.org To: Beilei Xing Return-path: Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id 3604D7CDE for ; Fri, 22 Sep 2017 15:39:31 +0200 (CEST) Received: by mail-wr0-f178.google.com with SMTP id k20so972121wre.4 for ; Fri, 22 Sep 2017 06:39:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1506119714-53437-5-git-send-email-beilei.xing@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Sep 23, 2017 at 06:35:10AM +0800, Beilei Xing wrote: > This patch adds GTP, GTPC and GTPU items for > generic flow API, and also exposes item fields > through the flow command. > > Signed-off-by: Beilei Xing > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > +static const enum index item_gtp[] = { > + ITEM_GTP_TEID, > + ITEM_NEXT, > + ZERO, > +}; > + > +static const enum index item_gtpc[] = { > + ITEM_GTP_TEID, > + ITEM_NEXT, > + ZERO, > +}; > + > +static const enum index item_gtpu[] = { > + ITEM_GTP_TEID, > + ITEM_NEXT, > + ZERO, > +}; Only item_gtp[] needs to be defined. GTPC and GTPU should use the same array. Apart from that: Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND