All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>,
	dwmw2@infradead.org, computersforpeace@gmail.com, richard@nod.at,
	cyrille.pitchen@wedev4u.fr, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h
Date: Sun, 24 Sep 2017 10:20:06 +0200	[thread overview]
Message-ID: <20170924102006.5aa42982@bbrezillon> (raw)
In-Reply-To: <b45f83d5-6a0b-64f2-2a3a-708e1a1e7f90@gmail.com>

On Sat, 23 Sep 2017 23:10:26 +0200
Marek Vasut <marek.vasut@gmail.com> wrote:

> On 09/23/2017 10:13 PM, Pavel Machek wrote:
> > C++ comments look wrong in kernel tree. Fix one.  
> 
> AFAIR they are now (sadly) accepted, but this patch works for me.

Works for me too. Here is my

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> Would be nice if trivial could pick it.

Hm, I'd recommend not doing that, otherwise we might end up with a
conflict if a patch modify something in this area.

> 
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> > index 6cd0f6b..849543f1 100644
> > --- a/include/linux/mtd/mtd.h
> > +++ b/include/linux/mtd/mtd.h
> > @@ -267,7 +267,7 @@ struct mtd_info {
> >  	 */
> >  	unsigned int bitflip_threshold;
> >  
> > -	// Kernel-only stuff starts here.
> > +	/* Kernel-only stuff starts here. */
> >  	const char *name;
> >  	int index;
> >  
> >   
> 
> 

  reply	other threads:[~2017-09-24  8:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-23 20:13 [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h Pavel Machek
2017-09-23 21:10 ` Marek Vasut
2017-09-24  8:20   ` Boris Brezillon [this message]
2017-09-24  8:23     ` Richard Weinberger
2017-10-06 11:55       ` Pavel Machek
2017-10-06 12:00         ` Richard Weinberger
2017-10-06 12:01           ` David Woodhouse
2017-10-06 12:13             ` Pavel Machek
2017-10-06 12:25               ` David Woodhouse
2017-10-12 10:31                 ` Alan Cox
2017-10-06 12:32               ` Al Viro
2017-10-06 13:04                 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170924102006.5aa42982@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=richard@nod.at \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.