From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752177AbdIXMFM (ORCPT ); Sun, 24 Sep 2017 08:05:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:35264 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751868AbdIXMFK (ORCPT ); Sun, 24 Sep 2017 08:05:10 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 943D1218B3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sun, 24 Sep 2017 13:05:06 +0100 From: Jonathan Cameron To: Christophe JAILLET Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, sre@kernel.org, wsa@the-dreams.de, kishon@ti.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/3] iio: adc: twl4030: Return an error if we can not enable the vusb3v1 regulator in 'twl4030_madc_probe()' Message-ID: <20170924130506.19e1b733@archlinux> In-Reply-To: <128d2bb662f174ed84c61dc268940bd87878f0d1.1506146101.git.christophe.jaillet@wanadoo.fr> References: <4bcd315895de7135369e6e0d2402fc2794f2ee99.1506146101.git.christophe.jaillet@wanadoo.fr> <128d2bb662f174ed84c61dc268940bd87878f0d1.1506146101.git.christophe.jaillet@wanadoo.fr> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 23 Sep 2017 08:06:20 +0200 Christophe JAILLET wrote: > If we can not enable the regulator, go through the error handling path > instead of silently continuing. > > Fixes: 7cc97d77ee8a ("iio: adc: twl4030: Fix ADC[3:6] readings") > Signed-off-by: Christophe JAILLET Applied to the fixes-togreg-post-rc1 branch of iio.git. I haven't explicitly marked this one for stable as it isn't broken as such, just inconsistent. Thanks, Jonathan > --- > This patch is highly speculative. > I don't find logical to return an error if we don't find the 'vusb3v1' > regulator, but continue if we find it, but can't enable it. > Returning an error if both cases (i.e. failing 'devm_regulator_get()' or > 'regulator_enable)' seems the usual pattern in all the .probe functions > with a 'regulator_enable()' call have looked at (~ 10 of them taken > randomly) > --- > drivers/iio/adc/twl4030-madc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c > index 32db23d9a483..e3cfb91bffc6 100644 > --- a/drivers/iio/adc/twl4030-madc.c > +++ b/drivers/iio/adc/twl4030-madc.c > @@ -893,8 +893,10 @@ static int twl4030_madc_probe(struct platform_device *pdev) > } > > ret = regulator_enable(madc->usb3v1); > - if (ret) > + if (ret) { > dev_err(madc->dev, "could not enable 3v1 bias regulator\n"); > + goto err_i2c; > + } > > ret = iio_device_register(iio_dev); > if (ret) { From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Date: Sun, 24 Sep 2017 12:05:06 +0000 Subject: Re: [PATCH 3/3] iio: adc: twl4030: Return an error if we can not enable the vusb3v1 regulator in 'tw Message-Id: <20170924130506.19e1b733@archlinux> List-Id: References: <4bcd315895de7135369e6e0d2402fc2794f2ee99.1506146101.git.christophe.jaillet@wanadoo.fr> <128d2bb662f174ed84c61dc268940bd87878f0d1.1506146101.git.christophe.jaillet@wanadoo.fr> In-Reply-To: <128d2bb662f174ed84c61dc268940bd87878f0d1.1506146101.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, sre@kernel.org, wsa@the-dreams.de, kishon@ti.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Sat, 23 Sep 2017 08:06:20 +0200 Christophe JAILLET wrote: > If we can not enable the regulator, go through the error handling path > instead of silently continuing. > > Fixes: 7cc97d77ee8a ("iio: adc: twl4030: Fix ADC[3:6] readings") > Signed-off-by: Christophe JAILLET Applied to the fixes-togreg-post-rc1 branch of iio.git. I haven't explicitly marked this one for stable as it isn't broken as such, just inconsistent. Thanks, Jonathan > --- > This patch is highly speculative. > I don't find logical to return an error if we don't find the 'vusb3v1' > regulator, but continue if we find it, but can't enable it. > Returning an error if both cases (i.e. failing 'devm_regulator_get()' or > 'regulator_enable)' seems the usual pattern in all the .probe functions > with a 'regulator_enable()' call have looked at (~ 10 of them taken > randomly) > --- > drivers/iio/adc/twl4030-madc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c > index 32db23d9a483..e3cfb91bffc6 100644 > --- a/drivers/iio/adc/twl4030-madc.c > +++ b/drivers/iio/adc/twl4030-madc.c > @@ -893,8 +893,10 @@ static int twl4030_madc_probe(struct platform_device *pdev) > } > > ret = regulator_enable(madc->usb3v1); > - if (ret) > + if (ret) { > dev_err(madc->dev, "could not enable 3v1 bias regulator\n"); > + goto err_i2c; > + } > > ret = iio_device_register(iio_dev); > if (ret) {