From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH rfc] nvme-cli: NVMf auto discovery systemd service
Date: Sun, 24 Sep 2017 16:56:05 +0200 [thread overview]
Message-ID: <20170924145605.GB14806@lst.de> (raw)
In-Reply-To: <1506258095-15916-1-git-send-email-sagi@grimberg.me>
This looks reasoanable to me, although I'm really not the expert
for systemd stuff.
Does it handle the case where /etc/nvme/discovery.conf is non-existent
(yes, you created in the specfile, but not everyone uses rpms).
> We can also add some documentation into discovery.conf to help
> the user add discovery endpoints.
That would be great for the default one, e.g. some example RDMA
and FC configfs.
next prev parent reply other threads:[~2017-09-24 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 13:01 [PATCH rfc] nvme-cli: NVMf auto discovery systemd service Sagi Grimberg
2017-09-24 14:56 ` Christoph Hellwig [this message]
2017-09-24 15:20 ` Sagi Grimberg
2017-09-25 7:55 ` Johannes Thumshirn
2017-09-25 13:22 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170924145605.GB14806@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.