From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752632AbdIXPkx convert rfc822-to-8bit (ORCPT ); Sun, 24 Sep 2017 11:40:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:39418 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474AbdIXPkv (ORCPT ); Sun, 24 Sep 2017 11:40:51 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E4C5214E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sun, 24 Sep 2017 16:40:47 +0100 From: Jonathan Cameron To: Stefan =?UTF-8?B?QnLDvG5z?= Cc: , , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler Subject: Re: [PATCH 0/4] iio: light: vl6180: Several fixes and enhancements Message-ID: <20170924164047.5f4869f5@archlinux> In-Reply-To: <20170919031144.4968-1-stefan.bruens@rwth-aachen.de> References: <20170919031144.4968-1-stefan.bruens@rwth-aachen.de> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Sep 2017 05:11:40 +0200 Stefan Brüns wrote: > Currently, the vl6180 driver reports bogus in_illuminance_scale values > when the integration time or hardware gain are changed from its default > value, i.e. it always reports a fixed value. > > To avoid readback of the register values in case integration time, gain > or scale is queried, save the register values. Use the saved values > to report the correct scale value. Hmm. I think unfortunately that this set is too large and invasive to send as a fix. Hence once the little corners are tidied up I'll take it via the slow path ready for the next merge window. Thanks, Jonathan > > Stefan Brüns (4): > iio: light: vl6180: Move range check to integration time setter, > cleanup > iio: light: vl6180: Avoid readback of integration time register > iio: light: vl6180: Cleanup als_gain lookup, avoid register readback > iio: light: vl6180: Correct ALS scale for non-default gain/integration > time > > drivers/iio/light/vl6180.c | 125 +++++++++++++++++++++++++-------------------- > 1 file changed, 69 insertions(+), 56 deletions(-) >