From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: speed up skb_rbtree_purge()
Date: Mon, 25 Sep 2017 20:36:11 -0700 (PDT) [thread overview]
Message-ID: <20170925.203611.1769058727594321517.davem@davemloft.net> (raw)
In-Reply-To: <1506195552.29839.214.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 23 Sep 2017 12:39:12 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> As measured in my prior patch ("sch_netem: faster rb tree removal"),
> rbtree_postorder_for_each_entry_safe() is nice looking but much slower
> than using rb_next() directly, except when tree is small enough
> to fit in CPU caches (then the cost is the same)
>
> Also note that there is not even an increase of text size :
> $ size net/core/skbuff.o.before net/core/skbuff.o
> text data bss dec hex filename
> 40711 1298 0 42009 a419 net/core/skbuff.o.before
> 40711 1298 0 42009 a419 net/core/skbuff.o
>
>
> From: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2017-09-26 3:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-23 19:39 [PATCH net-next] net: speed up skb_rbtree_purge() Eric Dumazet
2017-09-26 3:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925.203611.1769058727594321517.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.