From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Date: Mon, 25 Sep 2017 06:12:01 +0000 Subject: Re: [PATCH v5 0/4] Certificate insertion support for x86 bzImages Message-Id: <20170925061159.GA6934@rapoport-lnx> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: In-Reply-To: <1494440456-28671-1-git-send-email-mkayaalp@linux.vnet.ibm.com> To: linux-security-module@vger.kernel.org Hi, > These patches add support for modifying the reserved space for extra > certificates in a compressed bzImage in x86. This allows separating the > system keyring certificate from the kernel build process. After the kernel > image is distributed, the insert-sys-cert script can be used to insert the > certificate for x86. I know it's been a while since these patches were posted and they seem to fail between the cracks ... Is there anything that prevents merging them? > Changes: > > v5: > * Added CRC fixing (3/4) > > v4: > * Applied checkpatch.pl suggestions (2/4, 3/4) > * Cleaned up the commit messages (1/4, 2/4) > * Added the build file to .gitignore (1/4) > > v3: > * Rewrote 1/4 to insert incompressible bytes are at build time. Previous > solution required changes to /boot/Makefile's for modifying the > vmlinux file after linking, and did not work well with cross compilation. > * Added 2/4 for ELF class-independent processing of vmlinux file, in case > the script was compiled for 64-bit and the kernel was compiled for 32-bit. > * Reordered 3/4, added x86 bzImage boot version (>=2.08) verification. > > v2: > * Rebased arch/boot/x86/Makefile patch (removed in v3) > > Mehmet Kayaalp (4): > KEYS: Insert incompressible bytes to reserve space in bzImage > KEYS: Add ELF class-independent certificate insertion support > KEYS: Support for inserting a certificate into x86 bzImage > KEYS: Print insert-sys-cert information to stdout instead of stderr > > certs/.gitignore | 1 + > certs/Makefile | 21 +- > certs/system_certificates.S | 2 +- > scripts/Makefile | 1 + > scripts/insert-sys-cert.c | 473 +++++++++++++++++++++++++++++++++----------- > 5 files changed, 381 insertions(+), 117 deletions(-) -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932100AbdIYGML (ORCPT ); Mon, 25 Sep 2017 02:12:11 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58138 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753195AbdIYGMI (ORCPT ); Mon, 25 Sep 2017 02:12:08 -0400 Date: Mon, 25 Sep 2017 09:12:01 +0300 From: Mike Rapoport To: David Howells Cc: David Woodhouse , keyrings , LSM , kernel , Mimi Zohar , Stefan Berger , George Wilson , Mehmet Kayaalp Subject: Re: [PATCH v5 0/4] Certificate insertion support for x86 bzImages MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494440456-28671-1-git-send-email-mkayaalp@linux.vnet.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 17092506-0008-0000-0000-00000499BF65 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17092506-0009-0000-0000-00001E2B0447 Message-Id: <20170925061159.GA6934@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-25_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709250097 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > These patches add support for modifying the reserved space for extra > certificates in a compressed bzImage in x86. This allows separating the > system keyring certificate from the kernel build process. After the kernel > image is distributed, the insert-sys-cert script can be used to insert the > certificate for x86. I know it's been a while since these patches were posted and they seem to fail between the cracks ... Is there anything that prevents merging them? > Changes: > > v5: > * Added CRC fixing (3/4) > > v4: > * Applied checkpatch.pl suggestions (2/4, 3/4) > * Cleaned up the commit messages (1/4, 2/4) > * Added the build file to .gitignore (1/4) > > v3: > * Rewrote 1/4 to insert incompressible bytes are at build time. Previous > solution required changes to /boot/Makefile's for modifying the > vmlinux file after linking, and did not work well with cross compilation. > * Added 2/4 for ELF class-independent processing of vmlinux file, in case > the script was compiled for 64-bit and the kernel was compiled for 32-bit. > * Reordered 3/4, added x86 bzImage boot version (>=2.08) verification. > > v2: > * Rebased arch/boot/x86/Makefile patch (removed in v3) > > Mehmet Kayaalp (4): > KEYS: Insert incompressible bytes to reserve space in bzImage > KEYS: Add ELF class-independent certificate insertion support > KEYS: Support for inserting a certificate into x86 bzImage > KEYS: Print insert-sys-cert information to stdout instead of stderr > > certs/.gitignore | 1 + > certs/Makefile | 21 +- > certs/system_certificates.S | 2 +- > scripts/Makefile | 1 + > scripts/insert-sys-cert.c | 473 +++++++++++++++++++++++++++++++++----------- > 5 files changed, 381 insertions(+), 117 deletions(-) -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 From: rppt@linux.vnet.ibm.com (Mike Rapoport) Date: Mon, 25 Sep 2017 09:12:01 +0300 Subject: [PATCH v5 0/4] Certificate insertion support for x86 bzImages In-Reply-To: <1494440456-28671-1-git-send-email-mkayaalp@linux.vnet.ibm.com> Message-ID: <20170925061159.GA6934@rapoport-lnx> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org Hi, > These patches add support for modifying the reserved space for extra > certificates in a compressed bzImage in x86. This allows separating the > system keyring certificate from the kernel build process. After the kernel > image is distributed, the insert-sys-cert script can be used to insert the > certificate for x86. I know it's been a while since these patches were posted and they seem to fail between the cracks ... Is there anything that prevents merging them? > Changes: > > v5: > * Added CRC fixing (3/4) > > v4: > * Applied checkpatch.pl suggestions (2/4, 3/4) > * Cleaned up the commit messages (1/4, 2/4) > * Added the build file to .gitignore (1/4) > > v3: > * Rewrote 1/4 to insert incompressible bytes are at build time. Previous > solution required changes to /boot/Makefile's for modifying the > vmlinux file after linking, and did not work well with cross compilation. > * Added 2/4 for ELF class-independent processing of vmlinux file, in case > the script was compiled for 64-bit and the kernel was compiled for 32-bit. > * Reordered 3/4, added x86 bzImage boot version (>=2.08) verification. > > v2: > * Rebased arch/boot/x86/Makefile patch (removed in v3) > > Mehmet Kayaalp (4): > KEYS: Insert incompressible bytes to reserve space in bzImage > KEYS: Add ELF class-independent certificate insertion support > KEYS: Support for inserting a certificate into x86 bzImage > KEYS: Print insert-sys-cert information to stdout instead of stderr > > certs/.gitignore | 1 + > certs/Makefile | 21 +- > certs/system_certificates.S | 2 +- > scripts/Makefile | 1 + > scripts/insert-sys-cert.c | 473 +++++++++++++++++++++++++++++++++----------- > 5 files changed, 381 insertions(+), 117 deletions(-) -- Sincerely yours, Mike. -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html