From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965238AbdIYQNA (ORCPT ); Mon, 25 Sep 2017 12:13:00 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:38294 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964839AbdIYQM6 (ORCPT ); Mon, 25 Sep 2017 12:12:58 -0400 Date: Mon, 25 Sep 2017 17:12:21 +0100 From: Mark Brown To: Randy Dunlap Cc: LKML , linux-spi@vger.kernel.org Subject: Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m Message-ID: <20170925161221.v23dpeljin5kakhz@sirena.org.uk> References: <20170922092621.uq2xsvxangeetewi@sirena.org.uk> <9dc8b064-8a6c-98d2-4ade-088cbfd56fb1@infradead.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h3dlpnuuk6uvwtfp" Content-Disposition: inline In-Reply-To: <9dc8b064-8a6c-98d2-4ade-088cbfd56fb1@infradead.org> X-Cookie: MIT: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --h3dlpnuuk6uvwtfp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 22, 2017 at 06:46:46PM -0700, Randy Dunlap wrote: > On 09/22/17 02:26, Mark Brown wrote: > > right thing - if we can use hwspinlocks in a module when they're enabled > > I'd expect to be able to build the stubs that way too. > Sorry, I'm not understanding what you are trying to say on that one. > HWSPINLOCK SPI_SPRD_ADI > but this combo is not allowed (with the patch) or causes build errors > (without the patch): > m y Why is that not just an || COMPILE_TEST dependency then? The dependency you're trying to introduce is weird and confusing, we shouldn't be having to do things like that. --h3dlpnuuk6uvwtfp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlnJKuQACgkQJNaLcl1U h9ClSAf9HXapwrFbCjSOUCah0zc1oA5WhxRvwyOxF/q2IH2yN5nKJ4bc8yMxxXeo ruzy5zNQdshL6RKjY3aHp9weYV0E661UGCpaFxPZ8phtVtWZAWLx5/m/+1YxwqJt 7vDH3z9+pAeGad3KiBEF/RzOvKRfcbyWvYWTjiCDAhNk2bfJZfVTaDgwCQ87iYr0 o1UxB2qq9vPm9Zq0ci9ijb4LqpxbMUQYA8zyxcfhsrXnhKuLqQuHMJsl5TTOzzYe dZTkIXq8jwYyCdZ8M1+umMqD3NL3b1vDmZnRfZj/BuQ88d3Fd4YjszBGdmZzqz2x uqNlI30LKBCBlgl91Slwyu2T1acBPA== =OUIe -----END PGP SIGNATURE----- --h3dlpnuuk6uvwtfp-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m Date: Mon, 25 Sep 2017 17:12:21 +0100 Message-ID: <20170925161221.v23dpeljin5kakhz@sirena.org.uk> References: <20170922092621.uq2xsvxangeetewi@sirena.org.uk> <9dc8b064-8a6c-98d2-4ade-088cbfd56fb1@infradead.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h3dlpnuuk6uvwtfp" Cc: LKML , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Randy Dunlap Return-path: Content-Disposition: inline In-Reply-To: <9dc8b064-8a6c-98d2-4ade-088cbfd56fb1-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: --h3dlpnuuk6uvwtfp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 22, 2017 at 06:46:46PM -0700, Randy Dunlap wrote: > On 09/22/17 02:26, Mark Brown wrote: > > right thing - if we can use hwspinlocks in a module when they're enabled > > I'd expect to be able to build the stubs that way too. > Sorry, I'm not understanding what you are trying to say on that one. > HWSPINLOCK SPI_SPRD_ADI > but this combo is not allowed (with the patch) or causes build errors > (without the patch): > m y Why is that not just an || COMPILE_TEST dependency then? The dependency you're trying to introduce is weird and confusing, we shouldn't be having to do things like that. --h3dlpnuuk6uvwtfp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlnJKuQACgkQJNaLcl1U h9ClSAf9HXapwrFbCjSOUCah0zc1oA5WhxRvwyOxF/q2IH2yN5nKJ4bc8yMxxXeo ruzy5zNQdshL6RKjY3aHp9weYV0E661UGCpaFxPZ8phtVtWZAWLx5/m/+1YxwqJt 7vDH3z9+pAeGad3KiBEF/RzOvKRfcbyWvYWTjiCDAhNk2bfJZfVTaDgwCQ87iYr0 o1UxB2qq9vPm9Zq0ci9ijb4LqpxbMUQYA8zyxcfhsrXnhKuLqQuHMJsl5TTOzzYe dZTkIXq8jwYyCdZ8M1+umMqD3NL3b1vDmZnRfZj/BuQ88d3Fd4YjszBGdmZzqz2x uqNlI30LKBCBlgl91Slwyu2T1acBPA== =OUIe -----END PGP SIGNATURE----- --h3dlpnuuk6uvwtfp-- -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html