From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [RFC PATCH 3/8] ASoC: ACPI: add new fields for SOF support Date: Tue, 26 Sep 2017 09:48:08 +0530 Message-ID: <20170926041808.GK30097@localhost> References: <20170908205702.1985-1-pierre-louis.bossart@linux.intel.com> <20170908205702.1985-4-pierre-louis.bossart@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by alsa0.perex.cz (Postfix) with ESMTP id 88F50267056 for ; Tue, 26 Sep 2017 06:14:14 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20170908205702.1985-4-pierre-louis.bossart@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pierre-Louis Bossart Cc: tiwai@suse.de, liam.r.girdwood@linux.intel.com, alsa-devel@alsa-project.org, broonie@kernel.org List-Id: alsa-devel@alsa-project.org On Fri, Sep 08, 2017 at 03:56:57PM -0500, Pierre-Louis Bossart wrote: > To prepare for SOF integration, we need new fields in the machine table. > It is intended that the same table is used for both closed-source and > open-source firmware to avoid repeating ACPI-related information > multiple times > No functional change > > Signed-off-by: Pierre-Louis Bossart > --- > include/sound/soc-acpi.h | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/include/sound/soc-acpi.h b/include/sound/soc-acpi.h > index 75fb32e..3e61f93 100644 > --- a/include/sound/soc-acpi.h > +++ b/include/sound/soc-acpi.h > @@ -60,12 +60,29 @@ struct snd_soc_acpi_mach { > const char *drv_name; > /* firmware file name */ > const char *fw_filename; > - > /* board name */ > const char *board; > struct snd_soc_acpi_mach * (*machine_quirk)(void *arg); > const void *quirk_data; > + > + /* intended for platform data or machine specific-ops */ > void *pdata; > + > + /* SOF firmware file name */ > + const char *sof_fw_filename; > + /* SOF default topology */ > + const char *sof_tplg_filename; > + > + /* ASoC platform name - used for binding machine drivers if non NULL */ > + const char *asoc_plat_name; > + > + /* machine driver private data fixup */ > + struct platform_device * (*new_mach_data)(void *pdata); good comments, can we move them to kernel-doc style please > + > + /* FIXME: is this needed, was only used for BYTCR-detection > + int (*confirm_mach)(struct device *dev, > + const struct sof_dev_desc **desc); > + */ this is dummy, lets remove it and add when required -- ~Vinod