From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936548AbdIZGAZ (ORCPT ); Tue, 26 Sep 2017 02:00:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:59620 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934653AbdIZGAY (ORCPT ); Tue, 26 Sep 2017 02:00:24 -0400 Date: Tue, 26 Sep 2017 08:00:22 +0200 From: Jean Delvare To: Cc: , , , , Subject: Re: [PATCH] soc: mediatek: turn MTK_PMIC_WRAP into visible symbols Message-ID: <20170926080022.215f7b7b@endymion> In-Reply-To: <6c1696cf9f860cc8151a906ecbc799121b5aeeab.1505984256.git.sean.wang@mediatek.com> References: <6c1696cf9f860cc8151a906ecbc799121b5aeeab.1505984256.git.sean.wang@mediatek.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Sep 2017 17:01:05 +0800, sean.wang@mediatek.com wrote: > From: Sean Wang > > MTK_PMIC_WRAP is the basic and required configuration for those various > MediaTek PMICs, so turning MTK_PMIC_WRAP into visible symbols easily > allows users tending to have the enablement for those PMICs. I can't really make sense of the sentence above, sorry, and can't see how it matches the change below anyway. MTK_PMIC_WRAP is already a visible symbol before this change. The change is probably good in itself, but please try to come up with a better description. > Signed-off-by: Sean Wang > --- > drivers/soc/mediatek/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig > index a2fcd7f..d513629 100644 > --- a/drivers/soc/mediatek/Kconfig > +++ b/drivers/soc/mediatek/Kconfig > @@ -15,7 +15,7 @@ config MTK_INFRACFG > config MTK_PMIC_WRAP > tristate "MediaTek PMIC Wrapper Support" > depends on ARCH_MEDIATEK > - depends on RESET_CONTROLLER > + select RESET_CONTROLLER > select REGMAP > help > Say yes here to add support for MediaTek PMIC Wrapper found -- Jean Delvare SUSE L3 Support From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] soc: mediatek: turn MTK_PMIC_WRAP into visible symbols Date: Tue, 26 Sep 2017 08:00:22 +0200 Message-ID: <20170926080022.215f7b7b@endymion> References: <6c1696cf9f860cc8151a906ecbc799121b5aeeab.1505984256.git.sean.wang@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <6c1696cf9f860cc8151a906ecbc799121b5aeeab.1505984256.git.sean.wang@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: sean.wang@mediatek.com Cc: matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-mediatek@lists.infradead.org On Thu, 21 Sep 2017 17:01:05 +0800, sean.wang@mediatek.com wrote: > From: Sean Wang > > MTK_PMIC_WRAP is the basic and required configuration for those various > MediaTek PMICs, so turning MTK_PMIC_WRAP into visible symbols easily > allows users tending to have the enablement for those PMICs. I can't really make sense of the sentence above, sorry, and can't see how it matches the change below anyway. MTK_PMIC_WRAP is already a visible symbol before this change. The change is probably good in itself, but please try to come up with a better description. > Signed-off-by: Sean Wang > --- > drivers/soc/mediatek/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig > index a2fcd7f..d513629 100644 > --- a/drivers/soc/mediatek/Kconfig > +++ b/drivers/soc/mediatek/Kconfig > @@ -15,7 +15,7 @@ config MTK_INFRACFG > config MTK_PMIC_WRAP > tristate "MediaTek PMIC Wrapper Support" > depends on ARCH_MEDIATEK > - depends on RESET_CONTROLLER > + select RESET_CONTROLLER > select REGMAP > help > Say yes here to add support for MediaTek PMIC Wrapper found -- Jean Delvare SUSE L3 Support From mboxrd@z Thu Jan 1 00:00:00 1970 From: jdelvare@suse.de (Jean Delvare) Date: Tue, 26 Sep 2017 08:00:22 +0200 Subject: [PATCH] soc: mediatek: turn MTK_PMIC_WRAP into visible symbols In-Reply-To: <6c1696cf9f860cc8151a906ecbc799121b5aeeab.1505984256.git.sean.wang@mediatek.com> References: <6c1696cf9f860cc8151a906ecbc799121b5aeeab.1505984256.git.sean.wang@mediatek.com> Message-ID: <20170926080022.215f7b7b@endymion> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 21 Sep 2017 17:01:05 +0800, sean.wang at mediatek.com wrote: > From: Sean Wang > > MTK_PMIC_WRAP is the basic and required configuration for those various > MediaTek PMICs, so turning MTK_PMIC_WRAP into visible symbols easily > allows users tending to have the enablement for those PMICs. I can't really make sense of the sentence above, sorry, and can't see how it matches the change below anyway. MTK_PMIC_WRAP is already a visible symbol before this change. The change is probably good in itself, but please try to come up with a better description. > Signed-off-by: Sean Wang > --- > drivers/soc/mediatek/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig > index a2fcd7f..d513629 100644 > --- a/drivers/soc/mediatek/Kconfig > +++ b/drivers/soc/mediatek/Kconfig > @@ -15,7 +15,7 @@ config MTK_INFRACFG > config MTK_PMIC_WRAP > tristate "MediaTek PMIC Wrapper Support" > depends on ARCH_MEDIATEK > - depends on RESET_CONTROLLER > + select RESET_CONTROLLER > select REGMAP > help > Say yes here to add support for MediaTek PMIC Wrapper found -- Jean Delvare SUSE L3 Support