From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968561AbdIZMIC (ORCPT ); Tue, 26 Sep 2017 08:08:02 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:32839 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965484AbdIZMH7 (ORCPT ); Tue, 26 Sep 2017 08:07:59 -0400 Date: Tue, 26 Sep 2017 14:07:51 +0200 From: Peter Zijlstra To: Anna-Maria Gleixner Cc: LKML , Ingo Molnar , Christoph Hellwig , keescook@chromium.org, John Stultz , Thomas Gleixner Subject: Re: [PATCH 09/25] hrtimer: Reduce conditional code (hrtimer_reprogram()) Message-ID: <20170926120751.jccevul6nlhx6xea@hirez.programming.kicks-ass.net> References: <20170831105725.809317030@linutronix.de> <20170831105826.286561855@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170831105826.286561855@linutronix.de> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 31, 2017 at 12:23:37PM -0000, Anna-Maria Gleixner wrote: > The hrtimer_reprogram() is currently required only when > CONFIG_HIGH_RES_TIMERS is set. Additional bitfields of hrtimer_cpu_base > struct are high resolution timer specific as well. > > To simplify the hrtimer code, the behaviour of CONFIG_HIGH_RES_TIMERS and > !CONFIG_HIGH_RES_TIMERS should be similar. As preparation for this, the > function hrtimer_reprogram() and required hrtimer_cpu_base struct members > are moved outside the conditional area. This Changelog is impenetrable. That is, I've no idea what you're trying to say. As to the patch, that makes hrtimer_reprogram exist unconditionally, but the only callsite (so far) is condition on hrtimer_is_hres_active(), which can only be true if HIGH_RES. So what, except grow the image size, does this patch achieve?