From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S936929AbdIZMlE (ORCPT <rfc822;w@1wt.eu>);
        Tue, 26 Sep 2017 08:41:04 -0400
Received: from bombadil.infradead.org ([65.50.211.133]:59117 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934771AbdIZMlD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 26 Sep 2017 08:41:03 -0400
Date: Tue, 26 Sep 2017 14:40:58 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Anna-Maria Gleixner <anna-maria@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Christoph Hellwig <hch@lst.org>, keescook@chromium.org,
        John Stultz <john.stultz@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 17/25] hrtimer: Implementation of softirq hrtimer handling
Message-ID: <20170926124058.vrzrcn776qqi2dqw@hirez.programming.kicks-ass.net>
References: <20170831105725.809317030@linutronix.de>
 <20170831105826.921969670@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170831105826.921969670@linutronix.de>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 31, 2017 at 12:23:42PM -0000, Anna-Maria Gleixner wrote:
> @@ -184,6 +188,7 @@ struct hrtimer_cpu_base {
>  	unsigned int			clock_was_set_seq;
>  	bool				migration_enabled;
>  	bool				nohz_active;
> +	bool				softirq_activated;
>  	unsigned int			hres_active	: 1,
>  					in_hrtirq	: 1,
>  					hang_detected	: 1;

Why do we have bools and a bitfield? Should that not all be part of the
bitfield?