From: Su Yue <suy.fnst@cn.fujitsu.com>
To: <linux-btrfs@vger.kernel.org>
Subject: [PATCH 3/5] btrfs-progs: check: error or return value of repair_root_items()
Date: Wed, 27 Sep 2017 14:34:38 +0800 [thread overview]
Message-ID: <20170927063440.25961-4-suy.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <20170927063440.25961-1-suy.fnst@cn.fujitsu.com>
Return value of repair_root_items():
<0 on error
=0 does nothing
>0 if repair is enable, N roots is repaired;
else N roots is corrupted.
In the repair mode, there should be no error if return value is bigger
than 0.
Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
---
cmds-check.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmds-check.c b/cmds-check.c
index 3e2f9faa..adc4a934 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -14646,8 +14646,8 @@ int cmd_check(int argc, char **argv)
if (!init_extent_tree) {
ret = repair_root_items(info);
- err |= !!ret;
if (ret < 0) {
+ err = !!ret;
error("failed to repair root items: %s",
strerror(-ret));
goto close_out;
--
2.14.1
next prev parent reply other threads:[~2017-09-27 6:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 6:34 [PATCH 0/5] btrfs-progs: check: original and lowmem mode fix Su Yue
2017-09-27 6:34 ` [PATCH 1/5] btrfs-progs: check: return value of check_extent_refs() Su Yue
2017-10-05 17:46 ` David Sterba
2017-10-06 1:38 ` Su Yue
2017-10-06 16:19 ` David Sterba
2017-10-06 1:42 ` Su Yue
2017-09-27 6:34 ` [PATCH 2/5] btrfs-progs: check: call repair_root_items() before any repair Su Yue
2017-09-27 7:24 ` Qu Wenruo
2017-09-27 7:58 ` [PATCH v2 " Su Yue
2017-09-27 8:28 ` [PATCH v3 " Su Yue
2017-09-27 6:34 ` Su Yue [this message]
2017-09-27 6:34 ` [PATCH 4/5] btrfs-progs: check: check extent_inline_ref in lowmem Su Yue
2017-09-27 6:34 ` [PATCH 5/5] btrfs-progs: fsck-tests: 027/bad_extent_inline_ref_type Su Yue
2017-10-06 16:52 ` [PATCH 0/5] btrfs-progs: check: original and lowmem mode fix David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927063440.25961-4-suy.fnst@cn.fujitsu.com \
--to=suy.fnst@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.