All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: Jeremy Kerr <jk@ozlabs.org>
Cc: linuxppc-dev@lists.ozlabs.org, Meng YK Li <shlimeng@cn.ibm.com>
Subject: Re: [PATCH] powerpc: Fix action argument for cpufeatures-based TLB flush
Date: Wed, 27 Sep 2017 15:44:06 +1000	[thread overview]
Message-ID: <20170927154406.2f94b799@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <1506488151-9825-1-git-send-email-jk@ozlabs.org>

On Wed, 27 Sep 2017 12:55:51 +0800
Jeremy Kerr <jk@ozlabs.org> wrote:

> Commit 41d0c2ecde introduced calls to __flush_tlb_power[89] from the
> cpufeatures code, specifying the number of sets to flush.
> 
> However, these functions take an action argument, not a number of sets.
> This means we hit the BUG() in __flush_tlb_{206,300} when using
> cpufeatures-style configuration.
> 
> This change passes TLB_INVAL_SCOPE_GLOBAL instead.
> 
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> CC: Nicholas Piggin <npiggin@gmail.com>

Thanks for this, yes it's obviously correct. Sigh, I thought I'd posted
the the same thing, but I didn't actually send it to linuxppc-dev. I had
another one to use early_radix_enabled() rather than radix_enabled()
in the series too. I'll send it.

Reviewed-by: Nicholas Piggin <npiggin@gmail.com>

  reply	other threads:[~2017-09-27  5:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27  4:55 [PATCH] powerpc: Fix action argument for cpufeatures-based TLB flush Jeremy Kerr
2017-09-27  5:44 ` Nicholas Piggin [this message]
2017-10-05  4:22 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170927154406.2f94b799@roar.ozlabs.ibm.com \
    --to=npiggin@gmail.com \
    --cc=jk@ozlabs.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=shlimeng@cn.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.