From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751456AbdI2BlC (ORCPT ); Thu, 28 Sep 2017 21:41:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41652 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750826AbdI2BlB (ORCPT ); Thu, 28 Sep 2017 21:41:01 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C309B3680A Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Thu, 28 Sep 2017 20:40:56 -0500 From: Josh Poimboeuf To: Linus Torvalds Cc: the arch/x86 maintainers , kernel test robot , Ingo Molnar , Andrey Ryabinin , Matthias Kaehlcke , Alexander Potapenko , Andy Lutomirski , Arnd Bergmann , Dmitriy Vyukov , Miguel Bernal Marin , Peter Zijlstra , Thomas Gleixner , LKML , LKP Subject: Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4 Message-ID: <20170929014056.gzfge2efgwfxkokj@treble> References: <20170928074758.GS17200@yexl-desktop> <20170928164422.sl4z4sfbkyscbxrk@treble> <20170928170121.qpyyfjijuwdkfx7g@treble> <20170928191032.5fhnyrark5ebov4c@treble> <20170928215826.6sdpmwtkiydiytim@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 29 Sep 2017 01:41:01 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 28, 2017 at 04:53:09PM -0700, Linus Torvalds wrote: > On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf wrote: > > > > Reported-by: kernel test robot > > Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang") > > Signed-off-by: Josh Poimboeuf > > Side note: it's not like I personally need the credit, but in general > I really want people to pick up on who debugged the code and pointed > to the solution. That's often more of the work than the fix itself. > > The kernel test robot report looked to be ignored as a "gcc-4.4 is too > old to worry about" thing. People who then step up and analyze the > problem are rare as it is. They need to be credited in the commit > logs. > > We don't have any fixed format for that, but it's pretty free-form. So > we have tags like > > Root-caused-by: > Diagnosed-by: > Analyzed-by: > Debugged-by: > Bisected-by: > Fix-suggested-by: > > etc for giving credit to people who figured out some part of a bug > (and, having grepped for this, we also a _shitload_ of miss-spellings > of various things ;) Indeed, credit is important and I try to give it where it's due. Sorry for the snub! I anoint you with: Debugged-by: Linus Torvalds -- Josh From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7079494244805526854==" MIME-Version: 1.0 From: Josh Poimboeuf To: lkp@lists.01.org Subject: Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4 Date: Thu, 28 Sep 2017 20:40:56 -0500 Message-ID: <20170929014056.gzfge2efgwfxkokj@treble> In-Reply-To: List-Id: --===============7079494244805526854== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, Sep 28, 2017 at 04:53:09PM -0700, Linus Torvalds wrote: > On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf w= rote: > > > > Reported-by: kernel test robot > > Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clan= g") > > Signed-off-by: Josh Poimboeuf > = > Side note: it's not like I personally need the credit, but in general > I really want people to pick up on who debugged the code and pointed > to the solution. That's often more of the work than the fix itself. > = > The kernel test robot report looked to be ignored as a "gcc-4.4 is too > old to worry about" thing. People who then step up and analyze the > problem are rare as it is. They need to be credited in the commit > logs. > = > We don't have any fixed format for that, but it's pretty free-form. So > we have tags like > = > Root-caused-by: > Diagnosed-by: > Analyzed-by: > Debugged-by: > Bisected-by: > Fix-suggested-by: > = > etc for giving credit to people who figured out some part of a bug > (and, having grepped for this, we also a _shitload_ of miss-spellings > of various things ;) Indeed, credit is important and I try to give it where it's due. Sorry for the snub! I anoint you with: Debugged-by: Linus Torvalds -- = Josh --===============7079494244805526854==--