From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752093AbdI2IBe (ORCPT ); Fri, 29 Sep 2017 04:01:34 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:37052 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbdI2IBd (ORCPT ); Fri, 29 Sep 2017 04:01:33 -0400 X-Google-Smtp-Source: AOwi7QBu8ooqjG7w5fXOD4CGKWJrUyEsWo2UnoZXzf5+Agm+3eZjVP5UOiPhDh0vSGXts6pbacIJaA== Date: Fri, 29 Sep 2017 10:01:28 +0200 From: Ingo Molnar To: Josh Poimboeuf Cc: Linus Torvalds , the arch/x86 maintainers , kernel test robot , Andrey Ryabinin , Matthias Kaehlcke , Alexander Potapenko , Andy Lutomirski , Arnd Bergmann , Dmitriy Vyukov , Miguel Bernal Marin , Peter Zijlstra , Thomas Gleixner , LKML , LKP Subject: Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4 Message-ID: <20170929080128.eygnwju6rbegs3lh@gmail.com> References: <20170928074758.GS17200@yexl-desktop> <20170928164422.sl4z4sfbkyscbxrk@treble> <20170928170121.qpyyfjijuwdkfx7g@treble> <20170928191032.5fhnyrark5ebov4c@treble> <20170928215826.6sdpmwtkiydiytim@treble> <20170929014056.gzfge2efgwfxkokj@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170929014056.gzfge2efgwfxkokj@treble> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Josh Poimboeuf wrote: > On Thu, Sep 28, 2017 at 04:53:09PM -0700, Linus Torvalds wrote: > > On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf wrote: > > > > > > Reported-by: kernel test robot > > > Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang") > > > Signed-off-by: Josh Poimboeuf > > > > Side note: it's not like I personally need the credit, but in general > > I really want people to pick up on who debugged the code and pointed > > to the solution. That's often more of the work than the fix itself. > > > > The kernel test robot report looked to be ignored as a "gcc-4.4 is too > > old to worry about" thing. People who then step up and analyze the > > problem are rare as it is. They need to be credited in the commit > > logs. > > > > We don't have any fixed format for that, but it's pretty free-form. So > > we have tags like > > > > Root-caused-by: > > Diagnosed-by: > > Analyzed-by: > > Debugged-by: > > Bisected-by: > > Fix-suggested-by: > > > > etc for giving credit to people who figured out some part of a bug > > (and, having grepped for this, we also a _shitload_ of miss-spellings > > of various things ;) > > Indeed, credit is important and I try to give it where it's due. Sorry > for the snub! I anoint you with: > > Debugged-by: Linus Torvalds When applying the fix I went with: Diagnosed-by: Linus Torvalds Because I think 'diagnosing' a bug is a higher category, which implies debugging. ( Sometimes we refer to 'debugging a bug' as the reporter adding printks on request and printing out key state that helps understand the bug. It does not necessarily imply root-causing the bug. ) Also note that I added a "Reported-and-Bisected-by:" tag for the ktest robot, to further credit the fact that in addition to reporting a kernel crash, a specific commit was bisected to as well. I'll wait for another round of ktest robot testing to make sure the crash is indeed fixed. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2952891261168625993==" MIME-Version: 1.0 From: Ingo Molnar To: lkp@lists.01.org Subject: Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4 Date: Fri, 29 Sep 2017 10:01:28 +0200 Message-ID: <20170929080128.eygnwju6rbegs3lh@gmail.com> In-Reply-To: <20170929014056.gzfge2efgwfxkokj@treble> List-Id: --===============2952891261168625993== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable * Josh Poimboeuf wrote: > On Thu, Sep 28, 2017 at 04:53:09PM -0700, Linus Torvalds wrote: > > On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf = wrote: > > > > > > Reported-by: kernel test robot > > > Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Cl= ang") > > > Signed-off-by: Josh Poimboeuf > > = > > Side note: it's not like I personally need the credit, but in general > > I really want people to pick up on who debugged the code and pointed > > to the solution. That's often more of the work than the fix itself. > > = > > The kernel test robot report looked to be ignored as a "gcc-4.4 is too > > old to worry about" thing. People who then step up and analyze the > > problem are rare as it is. They need to be credited in the commit > > logs. > > = > > We don't have any fixed format for that, but it's pretty free-form. So > > we have tags like > > = > > Root-caused-by: > > Diagnosed-by: > > Analyzed-by: > > Debugged-by: > > Bisected-by: > > Fix-suggested-by: > > = > > etc for giving credit to people who figured out some part of a bug > > (and, having grepped for this, we also a _shitload_ of miss-spellings > > of various things ;) > = > Indeed, credit is important and I try to give it where it's due. Sorry > for the snub! I anoint you with: > = > Debugged-by: Linus Torvalds When applying the fix I went with: Diagnosed-by: Linus Torvalds Because I think 'diagnosing' a bug is a higher category, which implies debu= gging. = ( Sometimes we refer to 'debugging a bug' as the reporter adding printks on = request and printing out key state that helps understand the bug. It does= not = necessarily imply root-causing the bug. ) Also note that I added a "Reported-and-Bisected-by:" tag for the ktest robo= t, to = further credit the fact that in addition to reporting a kernel crash, a spe= cific = commit was bisected to as well. I'll wait for another round of ktest robot testing to make sure the crash i= s = indeed fixed. Thanks, Ingo --===============2952891261168625993==--