From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752123AbdI2KeE (ORCPT ); Fri, 29 Sep 2017 06:34:04 -0400 Received: from mga06.intel.com ([134.134.136.31]:55337 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbdI2KeD (ORCPT ); Fri, 29 Sep 2017 06:34:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,452,1500966000"; d="scan'208";a="133522261" Date: Fri, 29 Sep 2017 18:32:04 +0800 From: Ye Xiaolong To: Ingo Molnar Cc: Josh Poimboeuf , Linus Torvalds , the arch/x86 maintainers , Andrey Ryabinin , Matthias Kaehlcke , Alexander Potapenko , Andy Lutomirski , Arnd Bergmann , Dmitriy Vyukov , Miguel Bernal Marin , Peter Zijlstra , Thomas Gleixner , LKML , LKP Subject: Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4 Message-ID: <20170929103204.GA29800@yexl-desktop> References: <20170928074758.GS17200@yexl-desktop> <20170928164422.sl4z4sfbkyscbxrk@treble> <20170928170121.qpyyfjijuwdkfx7g@treble> <20170928191032.5fhnyrark5ebov4c@treble> <20170928215826.6sdpmwtkiydiytim@treble> <20170929014056.gzfge2efgwfxkokj@treble> <20170929080128.eygnwju6rbegs3lh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170929080128.eygnwju6rbegs3lh@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/29, Ingo Molnar wrote: > >* Josh Poimboeuf wrote: > >> On Thu, Sep 28, 2017 at 04:53:09PM -0700, Linus Torvalds wrote: >> > On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf wrote: >> > > >> > > Reported-by: kernel test robot >> > > Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang") >> > > Signed-off-by: Josh Poimboeuf >> > >> > Side note: it's not like I personally need the credit, but in general >> > I really want people to pick up on who debugged the code and pointed >> > to the solution. That's often more of the work than the fix itself. >> > >> > The kernel test robot report looked to be ignored as a "gcc-4.4 is too >> > old to worry about" thing. People who then step up and analyze the >> > problem are rare as it is. They need to be credited in the commit >> > logs. >> > >> > We don't have any fixed format for that, but it's pretty free-form. So >> > we have tags like >> > >> > Root-caused-by: >> > Diagnosed-by: >> > Analyzed-by: >> > Debugged-by: >> > Bisected-by: >> > Fix-suggested-by: >> > >> > etc for giving credit to people who figured out some part of a bug >> > (and, having grepped for this, we also a _shitload_ of miss-spellings >> > of various things ;) >> >> Indeed, credit is important and I try to give it where it's due. Sorry >> for the snub! I anoint you with: >> >> Debugged-by: Linus Torvalds > >When applying the fix I went with: > > Diagnosed-by: Linus Torvalds > >Because I think 'diagnosing' a bug is a higher category, which implies debugging. > >( Sometimes we refer to 'debugging a bug' as the reporter adding printks on > request and printing out key state that helps understand the bug. It does not > necessarily imply root-causing the bug. ) > >Also note that I added a "Reported-and-Bisected-by:" tag for the ktest robot, to >further credit the fact that in addition to reporting a kernel crash, a specific >commit was bisected to as well. > >I'll wait for another round of ktest robot testing to make sure the crash is >indeed fixed. The panic is gone with the fix patch for 4 times test. Tested-by: Ye Xiaolong Thanks, Xiaolong > >Thanks, > > Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1031127557137900840==" MIME-Version: 1.0 From: Ye Xiaolong To: lkp@lists.01.org Subject: Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4 Date: Fri, 29 Sep 2017 18:32:04 +0800 Message-ID: <20170929103204.GA29800@yexl-desktop> In-Reply-To: <20170929080128.eygnwju6rbegs3lh@gmail.com> List-Id: --===============1031127557137900840== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 09/29, Ingo Molnar wrote: > >* Josh Poimboeuf wrote: > >> On Thu, Sep 28, 2017 at 04:53:09PM -0700, Linus Torvalds wrote: >> > On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf wrote: >> > > >> > > Reported-by: kernel test robot >> > > Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for C= lang") >> > > Signed-off-by: Josh Poimboeuf >> > = >> > Side note: it's not like I personally need the credit, but in general >> > I really want people to pick up on who debugged the code and pointed >> > to the solution. That's often more of the work than the fix itself. >> > = >> > The kernel test robot report looked to be ignored as a "gcc-4.4 is too >> > old to worry about" thing. People who then step up and analyze the >> > problem are rare as it is. They need to be credited in the commit >> > logs. >> > = >> > We don't have any fixed format for that, but it's pretty free-form. So >> > we have tags like >> > = >> > Root-caused-by: >> > Diagnosed-by: >> > Analyzed-by: >> > Debugged-by: >> > Bisected-by: >> > Fix-suggested-by: >> > = >> > etc for giving credit to people who figured out some part of a bug >> > (and, having grepped for this, we also a _shitload_ of miss-spellings >> > of various things ;) >> = >> Indeed, credit is important and I try to give it where it's due. Sorry >> for the snub! I anoint you with: >> = >> Debugged-by: Linus Torvalds > >When applying the fix I went with: > > Diagnosed-by: Linus Torvalds > >Because I think 'diagnosing' a bug is a higher category, which implies deb= ugging. = > >( Sometimes we refer to 'debugging a bug' as the reporter adding printks o= n = > request and printing out key state that helps understand the bug. It doe= s not = > necessarily imply root-causing the bug. ) > >Also note that I added a "Reported-and-Bisected-by:" tag for the ktest rob= ot, to = >further credit the fact that in addition to reporting a kernel crash, a sp= ecific = >commit was bisected to as well. > >I'll wait for another round of ktest robot testing to make sure the crash = is = >indeed fixed. The panic is gone with the fix patch for 4 times test. Tested-by: Ye Xiaolong Thanks, Xiaolong > >Thanks, > > Ingo --===============1031127557137900840==--