From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxsj3-0007ox-0w for qemu-devel@nongnu.org; Fri, 29 Sep 2017 06:40:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxsiz-0000TF-6Z for qemu-devel@nongnu.org; Fri, 29 Sep 2017 06:40:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37576) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dxsiz-0000Sm-02 for qemu-devel@nongnu.org; Fri, 29 Sep 2017 06:40:53 -0400 Date: Fri, 29 Sep 2017 11:40:43 +0100 From: "Daniel P. Berrange" Message-ID: <20170929104043.GB11930@redhat.com> Reply-To: "Daniel P. Berrange" References: <1506679874-22284-1-git-send-email-a.perevalov@samsung.com> <1506679874-22284-2-git-send-email-a.perevalov@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1506679874-22284-2-git-send-email-a.perevalov@samsung.com> Subject: Re: [Qemu-devel] [PATCH] configure: correctly define PTHREAD_LIB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Perevalov Cc: qemu-devel@nongnu.org, i.maximets@samsung.com, heetae82.ahn@samsung.com, quintela@redhat.com, dgilbert@redhat.com, peterx@redhat.com List-ID: On Fri, Sep 29, 2017 at 01:11:14PM +0300, Alexey Perevalov wrote: > In case of -pthread already exists in QEMU_CFLAGS, > compilation of sample pthread program successed, > but -pthread is not putting into PTHREAD_LIBS in this case. > PTHREAD_LIB is using while compiling tests/migration/stress. > > Signed-off-by: Alexey Perevalov > --- > configure | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configure b/configure > index 6587e80..a2dd044 100755 > --- a/configure > +++ b/configure > @@ -3359,6 +3359,7 @@ int main(void) { > EOF > if compile_prog "" "" ; then > pthread=yes > + PTHREAD_LIB="-pthread" > else > for pthread_lib in $PTHREADLIBS_LIST; do > if compile_prog "" "$pthread_lib" ; then We shouldn't do this because it affects whole of QEMU. The stress program needs -lpthread because it is linking statically, so just add it to the Makefile rule for building stress. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|