From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752820AbdI3KkA (ORCPT ); Sat, 30 Sep 2017 06:40:00 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:44532 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751677AbdI3Kj6 (ORCPT ); Sat, 30 Sep 2017 06:39:58 -0400 Date: Sat, 30 Sep 2017 12:39:46 +0200 From: Martin Schwidefsky To: Heiko Carstens Cc: Kirill Tkhai , linux-ia64@vger.kernel.org, avagin@virtuozzo.com, peterz@infradead.org, hpa@zytor.com, gorcunov@virtuozzo.com, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, x86@kernel.org, mingo@redhat.com, mattst88@gmail.com, fenghua.yu@intel.com, arnd@arndb.de, ink@jurassic.park.msu.ru, tglx@linutronix.de, rth@twiddle.net, tony.luck@intel.com, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, davem@davemloft.net, rientjes@google.com, viro@zeniv.linux.org.uk Subject: Re: [PATCH REBASED 3/6] s390: Add __down_read_killable() In-Reply-To: <20170930123612.0fb250fe@mschwideX1> References: <150670038738.23930.7190484711222807884.stgit@localhost.localdomain> <150670117817.23930.13068785028558453848.stgit@localhost.localdomain> <20170930092002.GA4623@osiris> <20170930123612.0fb250fe@mschwideX1> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17093010-0008-0000-0000-0000049B6C12 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17093010-0009-0000-0000-00001E2CC99F Message-Id: <20170930123946.7bb586c2@mschwideX1> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-30_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709300159 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 30 Sep 2017 12:36:12 +0200 Martin Schwidefsky wrote: > On Sat, 30 Sep 2017 11:20:02 +0200 > Heiko Carstens wrote: > > > On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote: > > > Similar to __down_write_killable(), and read killable primitive. > > > > > > Signed-off-by: Kirill Tkhai > > > --- > > > arch/s390/include/asm/rwsem.h | 18 ++++++++++++++++-- > > > 1 file changed, 16 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/s390/include/asm/rwsem.h b/arch/s390/include/asm/rwsem.h > > > > FWIW, while looking into this patch I realized that we never optimized our > > rwsem primitives to make use of new atomic instructions. > > > > The generic rwsem header file however does, since it uses atomic ops which > > we did optimize. Even when compiling for old machines the generic version > > generates better code. Therefore I will remove the 15 years old s390 > > implementation and switch to the generic version instead. > > Take care not to conflict with the queued spinlock/rwlock patches on the > features branch. > > https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit/?h=features&id=eb3b7b848fb3dd00f7a57d633d4ae4d194aa7865 > > Me thinks that what you have in mind is already done. Argh, pitfall rwlock != rwsem. Using the atomic_ops for the rwsem code makes a lot of sense. Yes, please.. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Schwidefsky Date: Sat, 30 Sep 2017 10:39:46 +0000 Subject: Re: [PATCH REBASED 3/6] s390: Add __down_read_killable() Message-Id: <20170930123946.7bb586c2@mschwideX1> List-Id: References: <150670038738.23930.7190484711222807884.stgit@localhost.localdomain> <150670117817.23930.13068785028558453848.stgit@localhost.localdomain> <20170930092002.GA4623@osiris> <20170930123612.0fb250fe@mschwideX1> In-Reply-To: <20170930123612.0fb250fe@mschwideX1> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Heiko Carstens Cc: Kirill Tkhai , linux-ia64@vger.kernel.org, avagin@virtuozzo.com, peterz@infradead.org, hpa@zytor.com, gorcunov@virtuozzo.com, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, x86@kernel.org, mingo@redhat.com, mattst88@gmail.com, fenghua.yu@intel.com, arnd@arndb.de, ink@jurassic.park.msu.ru, tglx@linutronix.de, rth@twiddle.net, tony.luck@intel.com, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, davem@davemloft.net, rientjes@google.com, viro@zeniv.linux.org.uk On Sat, 30 Sep 2017 12:36:12 +0200 Martin Schwidefsky wrote: > On Sat, 30 Sep 2017 11:20:02 +0200 > Heiko Carstens wrote: >=20 > > On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote: =20 > > > Similar to __down_write_killable(), and read killable primitive. > > >=20 > > > Signed-off-by: Kirill Tkhai > > > --- > > > arch/s390/include/asm/rwsem.h | 18 ++++++++++++++++-- > > > 1 file changed, 16 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/arch/s390/include/asm/rwsem.h b/arch/s390/include/asm/rw= sem.h =20 > >=20 > > FWIW, while looking into this patch I realized that we never optimized = our > > rwsem primitives to make use of new atomic instructions. > >=20 > > The generic rwsem header file however does, since it uses atomic ops wh= ich > > we did optimize. Even when compiling for old machines the generic versi= on > > generates better code. Therefore I will remove the 15 years old s390 > > implementation and switch to the generic version instead. =20 >=20 > Take care not to conflict with the queued spinlock/rwlock patches on the > features branch.=20 >=20 > https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit/?h= =FEatures&id=EB3b7b848fb3dd00f7a57d633d4ae4d194aa7865 >=20 > Me thinks that what you have in mind is already done. Argh, pitfall rwlock !=3D rwsem. Using the atomic_ops for the rwsem code ma= kes a lot of sense. Yes, please.. --=20 blue skies, Martin. "Reality continues to ruin my life." - Calvin.