All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Michal Hocko <mhocko@kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Alexander Potapenko <glider@google.com>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH] mm: kill kmemcheck again
Date: Sat, 30 Sep 2017 20:02:41 +0000	[thread overview]
Message-ID: <20170930200239.ngcyp2tcpuidpctv@sasha-lappy> (raw)
In-Reply-To: <CAOMGZ=FHDXRLZbq20zAFh+0w4zk4F4dUxsDd0amsyMo3Cb2ZrA@mail.gmail.com>

On Sat, Sep 30, 2017 at 03:57:27PM +0200, Vegard Nossum wrote:
>On 30 September 2017 at 11:48, Steven Rostedt <rostedt@goodmis.org> wrote:
>> On Wed, 27 Sep 2017 17:02:07 +0200
>> Michal Hocko <mhocko@kernel.org> wrote:
>>
>>> > Now that 2 years have passed, and all distros provide gcc that supports
>>> > KASAN, kill kmemcheck again for the very same reasons.
>>>
>>> This is just too large to review manually. How have you generated the
>>> patch?
>>
>> I agree. This needs to be taken out piece by piece, not in one go,
>> where there could be unexpected fallout.
>
>I have a patch from earlier this year that starts by removing the core
>code and defining all the helpers/flags as no-ops so they can be
>removed bit by bit at a later time. See the attachment. Pekka signed
>off on it too.
>e
>I never actually submitted this because I was waiting for MSAN to be

I'm not sure how much value there is in doing it this way. I agree that the patch is big, but most of it is simply removing code under arch/x86/mm/kmemcheck.

The difference between Vegard's patch and mine is about 300 lines (out of 2800+), where those 300 lines are simply removing calls to kmemcheck. There are no logic changes. (so something very similar to 's/*kmemcheck*//g' would do the trick).

--

Thanks,
Sasha

  reply	other threads:[~2017-09-30 20:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27 11:27 [PATCH] mm: kill kmemcheck again Levin, Alexander (Sasha Levin)
2017-09-27 11:32 ` Levin, Alexander (Sasha Levin)
2017-09-27 15:02 ` Michal Hocko
2017-09-27 15:24   ` Levin, Alexander (Sasha Levin)
2017-09-27 17:36     ` Eric W. Biederman
2017-09-27 22:01       ` Levin, Alexander (Sasha Levin)
2017-09-30  9:48   ` Steven Rostedt
2017-09-30 13:57     ` Vegard Nossum
2017-09-30 20:02       ` Levin, Alexander (Sasha Levin) [this message]
2017-10-02  7:29         ` Michal Hocko
2017-10-03 21:02           ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170930200239.ngcyp2tcpuidpctv@sasha-lappy \
    --to=alexander.levin@verizon.com \
    --cc=akpm@linux-foundation.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=davem@davemloft.net \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.