From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Sat, 30 Sep 2017 16:32:52 -0400 Subject: [U-Boot] [PATCH] dm: core: Correct address cast in dev_read_addr_ptr() In-Reply-To: <77060396-B38C-4268-8FB5-C1160A2E4089@theobroma-systems.com> References: <20170928123515.154787-1-sjg@chromium.org> <8FB48CB7-C8E3-431E-A214-BB9CF54AED69@theobroma-systems.com> <77060396-B38C-4268-8FB5-C1160A2E4089@theobroma-systems.com> Message-ID: <20170930203252.GA3503@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Sat, Sep 30, 2017 at 06:08:02PM +0200, Dr. Philipp Tomsich wrote: > Simon, > > > On 28 Sep 2017, at 18:14, Dr. Philipp Tomsich wrote: > > > > > >> On 28 Sep 2017, at 14:35, Simon Glass wrote: > >> > >> This currently causes a warning in sandbox and will not do the right > >> thing: > >> > >> drivers/core/read.c: In function ‘dev_read_addr_ptr’: > >> drivers/core/read.c:64:44: warning: cast to pointer from integer of > >> different size [-Wint-to-pointer-cast] > >> return (addr == FDT_ADDR_T_NONE) ? NULL : (void *)addr; > >> > >> Use map_sysmem() which is the correct way to convert an address to a > >> pointer. > >> > >> Fixes: c131c8bca8 (dm: core: add dev_read_addr_ptr()) > >> Signed-off-by: Simon Glass > > > > Reviewed-by: Philipp Tomsich > > > Acked-by: Philipp Tomsich > > I’ll pull this one in through u-boot-rockchip now, as Tom raised it as a build > issue against my last pull-request. Well, that's for the minor existing warning. The big problem is the build failures :) -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: