From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyyn2-000179-8b for qemu-devel@nongnu.org; Mon, 02 Oct 2017 07:21:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyymz-0001XG-44 for qemu-devel@nongnu.org; Mon, 02 Oct 2017 07:21:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41820) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dyymy-0001VK-U8 for qemu-devel@nongnu.org; Mon, 02 Oct 2017 07:21:33 -0400 Date: Mon, 2 Oct 2017 12:21:25 +0100 From: "Daniel P. Berrange" Message-ID: <20171002112125.GI27086@redhat.com> Reply-To: "Daniel P. Berrange" References: <1506933058-28313-1-git-send-email-a.perevalov@samsung.com> <1506933058-28313-2-git-send-email-a.perevalov@samsung.com> <20171002111739.GH27086@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] Makefile: don't use LINKPROG for tests/migration/stress List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Alexey Perevalov , heetae82.ahn@samsung.com, Juan Quintela , "Dr. David Alan Gilbert" , Peter Xu , QEMU Developers , i.maximets@samsung.com List-ID: On Mon, Oct 02, 2017 at 12:19:54PM +0100, Peter Maydell wrote: > On 2 October 2017 at 12:17, Daniel P. Berrange wrote: > > On Mon, Oct 02, 2017 at 12:14:39PM +0100, Peter Maydell wrote: > >> Why does this executable need to define its own link rule anyway? > >> Ideally it should just use the standard rules.mak LINK function > >> like everything else. If it does need to do something weird > >> it should have a comment saying why it's weird... > > > > Primarily because we're static linking this binary so that it can be put > > into an initrd without needing any extra files added. It doesn't use any > > of the 3rd party libraries the rest of QEMU uses - ie no glib2 in particular. > > Oh, are we committing our usual error of trying to build guest > binaries with the host toolchain? That's not an error here - this test suite is only intended to run with matching host/guest arch, and boots with the host kernel + custom initrd containing only this binary. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|